384752 - onItem* notifications are dispatched for closed containers (was: lots of assertions ("Removing item we don't have" and "Invalid index for item adding") when I reload a live bookmark and the bookmark organizer window is open)

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[(not reading, please use [e-mail] instead)]

lots of assertions when I reload a live bookmark and the bookmark organizer window is open:

I'm getting a lot of these:

###!!! ASSERTION: Removing item we don't have: 'Not Reached', file c:/builds/tru
nk/mozilla/toolkit/components/places/src/nsNavHistoryResult.cpp, line 3110

followed by a lot of these:

###!!! ASSERTION: Invalid index for item adding: greater than count: 'Not Reache
d', file c:/builds/trunk/mozilla/toolkit/components/places/src/nsNavHistoryResul
t.cpp, line 3038

steps to reproduce:

1) create a new profile
2) open the bm manager window
3) right click on the "latest headlines" rss feed and do "reload live bookmark"

I'm using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/20070615 Minefield/3.0a6pre

[note, I see this with and without the fix for bug #383572]

Comment 1

[Asaf Romano (gone)]

Morphing a bit, this is also the cause for various random front-end assertions.

Comment 2

[Dietrich Ayala (:dietrich)]

http://lxr.mozilla.org/mozilla/source/toolkit/components/places/src/nsNavHistoryResult.cpp#1187

see also https://bugzilla.mozilla.org/show_bug.cgi?id=386243#c2

Comment 3

[Asaf Romano (gone)]

So, to summarize:
  1. The contents of a bm folder is built once containerOpen = true is set on the
     container.
  2. The contents are _not_ destroyed when the container is closed, unlike
     complex queries, thus the bookmark observers are still set as well. This is
     all by design since incremental update for simple folder result nodes is
     cheap.
  1. Only one view->Item...() caller in nsNavHistoryFolderResultNode has that in
     mind.

Comment 4

[Asaf Romano (gone)]

Attachment: patch

Comment 5

[Dietrich Ayala (:dietrich)]

Comment on attachment 281078 [details] [diff] [review]
patch

r=me, thanks

Comment 6

[Asaf Romano (gone)]

mozilla/toolkit/components/places/src/nsNavHistoryResult.cpp 1.114

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv