385 - GH_InitGlobalHistory called too soon

Status: VERIFIED FIXED

(MozillaClassic Graveyard :: XFE, defect, P3)

Description

[Ronan Waide]

Created by Ronan Waide ([e-mail]) on Wednesday, May 20, 1998 4:05:03 AM PDT
Additional Details :
GH_InitGlobalHistory is called before FE_GlobalHist is set
from the preferences file, meaning that gh_open_database
doesn't have a filename to work with. Here's a patch to
main()/mozilla-main() to fix this:

Index: cmd/xfe/mozilla.c
===================================================================
RCS file: /cvsroot/mozilla/cmd/xfe/mozilla.c,v
retrieving revision 3.5
diff -c -r3.5 mozilla.c
*** mozilla.c   1998/05/14 09:18:26     3.5
--- mozilla.c   1998/05/20 11:02:04
***************
*** 2799,2812 ****
    PREF_SetDefaultCharPref("profile.directory",
fe_config_dir);
    PREF_SetDefaultIntPref("profile.numprofiles", 1);

-   GH_InitGlobalHistory();
-
    /* SECNAV_INIT needs this defined, but
build_user_agent_string cannot
     * be called until after SECNAV_INIT, so call this
simplified version.
     */
    build_simple_user_agent_string(versionLocale);

    fe_InstallPreferences (0);

    /*
    ** Initialize the security library.
--- 2799,2812 ----
    PREF_SetDefaultCharPref("profile.directory",
fe_config_dir);
    PREF_SetDefaultIntPref("profile.numprofiles", 1);

    /* SECNAV_INIT needs this defined, but
build_user_agent_string cannot
     * be called until after SECNAV_INIT, so call this
simplified version.
     */
    build_simple_user_agent_string(versionLocale);

    fe_InstallPreferences (0);
+
+   GH_InitGlobalHistory();

    /*
    ** Initialize the security library.
Updated by Steve Lamm ([e-mail]) on Wednesday, May 20, 1998 6:43:36 PM PDT
Additional Details :
The patch looks good.
I checked it in.
Updated by Steve Lamm ([e-mail]) on Wednesday, May 20, 1998 6:44:18 PM PDT
Additional Details :
Marking resolved.

Comment 1

[Matthias Versen [:Matti]]

mid-air collision ? / bugzilla cleanup
Reopening (current State: resolved and no resolution)

Comment 2

[Matthias Versen [:Matti]]

marking fixed

Comment 3

[Brant Gurganus]

VERIFIED due to no changes in over a year