385521 - leaksoup trace-malloc reader shouldn't use NS_QuickSort

Status: RESOLVED WORKSFORME

(Core :: XPCOM, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The leaksoup trace-malloc reader uses NS_QuickSort to sort lists by numbers that it assigned to nodes in order (of various graph traversals).  It should instead allocate an array for both of these sorts and fill in the array as it assigns the numbers.

Comment 1

[Serge Gautherie (:sgautherie)]

/tools/trace-malloc/leaksoup.cpp
    * line 44 -- #include "nsQuickSort.h"
    * line 244 -- NS_QuickSort(sorted_nodes, count, sizeof(AllocationNode*),
    * line 319 -- NS_QuickSort(sorted_nodes, count, sizeof(AllocationNode*),

Comment 2

[Edwin]

Hello, my friend and I would like to help out Mozilla, and we believe this is a good bug for us to start with. Is this bug still open? And if so, what are the first steps we should to get started.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I didn't mark this as [good first bug], and I don't think it is; I think good first bugs are much more likely to be ones where the purpoe of fixing the bug is more apparent (unlike, say, fixing a performance problem in a memory leak debugging tool used by only a few developers).

Comment 4

[Andrew McCreight [:mccr8]]

trace-malloc was removed in bug 1014341.