385569 - Dynamic cross-element ligature leaves space between parts of the ligature

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a6pre) Gecko/20070622 Minefield/3.0a6pre

In the testcase, you get the "fi" ligature form, but there are a few blank pixels between the "f" part and the "i" part.

Comment 1

[Jesse Ruderman]

Attachment: better testcase

Easier to make a "sane" reftest pair if there's a <span> in there.  By "sane" I mean that Firefox 2 (which doesn't attempt to do cross-element ligatures at all) can pass.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: slightly more difficult testcase

This testcase uses a nested span to hide the new element, which is slightly more difficult to fix (bug still fixed by the patch in bug 385607). I'll make these tests into reftests when that patch lands.

Comment 3

[Jesse Ruderman]

Seems to have been fixed by bug 385607.  roc, do you still want to make the reftests, or should I?

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

If you could, that would be great, thanks.

Comment 5

[Jesse Ruderman]

Reftests checked in.