385857 - multipart/form-data submission broken on 0.8

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[aaronr]

Attachment: patch

Looks like there is a bug on the 1.8 branch that prevents the patch that fixed multipart/form-data on the trunk from working on the branch.  When we go to set the nsXFormsAtoms::uploadFileProperty on the clone of the instance data node that originally contained it, it is failing to work correctly.  By that point we've already done the ImportNode, but not the AppendChild.  ImportNode should set up the owner document for the cloned node to be the submission document, but that doesn't seem to be the case since the owner document before appendchild and after are different.

So to work around this 1.8 bug we'll just set the property AFTER we've done the call to AppendChild.

Testcase: https://bugzilla.mozilla.org/attachment.cgi?id=247929

Comment 1

[aaronr]

checked into trunk

Comment 2

[aaronr]

Reopening bug.  I didn't move the statement high enough to fix uploads bound to attributes.

Comment 3

[aaronr]

Attachment: patch2

just asking for one review.  It is a pretty minor change, more of a correction of the first change.  But I don't want to be accused of breaking the rules :-)

Comment 4

[aaronr]

checked patch2 into trunk and patches 1 and 2 into 1.8 branch.