385970 - Drag and drop at index 0 of open folders reacts incorrectly to mouse position

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Christine Yen]

In general, DnD within a tree has to resolve the location of the mouse (which row it's hovering over, as seen by the tree) with where the the drop indicator is telling the user that the item will be dropped.

In http://mxr.mozilla.org/seamonkey/source/browser/components/places/content/tree.xml#898,
if 'orientation' == -1, insert above hovered row, ending up at 'index'
if 'orientation' == 1, insert below the hovered row, ending up at 'index' + 1

This behavior messes up DnD around folders, where the second case -- where the drop indicator tells the user that the item should be inserted at index 0 in the folder -- actually causes the orientation to be set to 1 and for the item to be inserted below the hovered row, or one row below the folder in the parent container. This is what causes the "popping out of the folder" effect seen in Bug #381751.

Comment 1

[Christine Yen]

Attachment: patch

Comment 2

[Christine Yen]

Attachment: previous patch, minus the typo in the header

Comment 3

[Christine Yen]

Attachment: patch v2

Comment 4

[(not reading, please use [e-mail] instead)]

Comment on attachment 269940 [details] [diff] [review]
patch v2

r=sspitzer

Comment 5

[(not reading, please use [e-mail] instead)]

fix landed along with bug #382679

Comment 6

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre)
Gecko/2007072505 Minefield/3.0a7pre

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv