387181 - Remove unneeded mozconfig options

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Adam Guthrie]

The following two options for the mozconfig are unneeded:

ac_add_options --enable-libxul
ac_add_options --enable-places-bookmarks

rhelmer added these when he changed from argo-vm to this box, and I told him they were unneeded (in some bug comment), but they never got changed.

Removing these is good because:

a) If will remove unnecessary cruft from the mozconfig and make it less confusing.
b) We shouldn't add unnecessary dependencies to the mozconfig (i.e. if someone changes the default for one of these in configure.in, they'll have to update the mozconfig here).
c) Precedence: None of the other tinderboxen have these options in their mozconfigs.

Comment 1

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Will be done after new ref platform is in use, and stable.

Comment 2

[Steffen Wilberg]

These are the defaults on all platforms:
ac_add_options --enable-canvas
ac_add_options --enable-svg

cairo-gtk2 is the only available toolkit on Linux, and "Pango is required for cairo gfx builds":
ac_add_options --enable-default-toolkit=cairo-gtk2
ac_add_options --enable-pango

So let's remove these options from mozconfig as well.

Comment 3

[Benjamin Smedberg]

Care to provide a patch? All configs are in CVS.

Comment 4

[Steffen Wilberg]

Attachment: patch

On Linux, remove the options mentioned in comment 0 and comment 2.
On Mac, just remove svg and canvas.
On Windows, remove svg, canvas, and default-toolkit=cairo-windows.

Tested on Linux, where everything (svg, canvas, places) works fine.

Comment 5

[Steffen Wilberg]

Checked in.