Closed
Bug 387212
Opened 17 years ago
Closed 17 years ago
[FIX]Nix direct same-origin checks in htmldocument, window, docshell
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha8
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
9.68 KB,
patch
|
mrbkap
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
Use Equals() and Subsumes() instead. Note that Subsumes() isn't as strict now as it was when the nsGlobalWindow timeout stuff was written. It does the right check now, I think.
Attachment #271329 -
Flags: superreview?(jst)
Attachment #271329 -
Flags: review?(mrbkap)
|
Assignee | |
Comment 1•17 years ago
|
||
Though as I said in bug 370113, some of the nsDocument checks that call this code should perhaps be ownerDocument compares, not same-origin compares.
|
||
Updated•17 years ago
|
Attachment #271329 -
Flags: superreview?(jst) → superreview+
|
||
Updated•17 years ago
|
Attachment #271329 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Comment 2•17 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Flags: in-testsuite?
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•