Closed
Bug 388048
Opened 17 years ago
Closed 17 years ago
mozIStorageStatement::getParameterIndexes is useless
Categories
(Toolkit :: Storage, defect)
Toolkit
Storage
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha8
People
(Reporter: sdwilsh, Assigned: sdwilsh)
References
Details
Attachments
(2 files)
|
847 bytes,
text/plain
|
Details | |
|
6.99 KB,
patch
|
moco
:
review+
|
Details | Diff | Splinter Review |
It returns an array in case it was used more than once, but sqlite magically takes care of that for us. It should be renamed to getParameterIndex and return an int. Attached is a testcase demonstrating that sqlite does in fact handle this gracefully.
|
Assignee | |
Comment 1•17 years ago
|
||
On the right bug too :)
Attachment #272284 -
Flags: review?(sspitzer)
|
||
Comment 2•17 years ago
|
||
Comment on attachment 272284 [details] [diff] [review] v1.0 r=sspitzer
Attachment #272284 -
Flags: review?(sspitzer) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Checking in storage/public/mozIStorageStatement.idl; new revision: 1.7; previous revision: 1.6 Checking in storage/src/mozStorageStatement.cpp; new revision: 1.23; previous revision: 1.22 Checking in storage/test/unit/test_storage_statement.js; new revision: 1.3; previous revision: 1.2
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta1
You need to log in
before you can comment on or make changes to this bug.
Description
•