Closed Bug 388325 Opened 17 years ago Closed 17 years ago

Stop using exceptions as part of the normal bookmark code flow

Categories

(Camino Graveyard :: Bookmarks, defect)

Product:
Camino Graveyard
Component:
Bookmarks
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Camino1.6

People

(Reporter: stuart.morgan+bugzilla, Assigned: stuart.morgan+bugzilla)

Details

(Keywords: fixed1.8.1.8)

Attachments

(1 file)

fix
2.28 KB, patch
hwaara
: review+
mikepinkerton
: superreview+
Details | Diff | Splinter Review 
Per IRC, bookmarks uses exceptions to handle showing folder counts in the bookmark manager (and possibly in other non-exceptional ways). Definitely not something we should be doing.
Attached patch fix — — Splinter Review 

        Attachment #272646 -
        Flags: review?(nick.kreeger)

    
    

    
  
This behavior is blocking some of peeja's SoC work.

    
    

    
  
Comment on attachment 272646 [details] [diff] [review]
fix

I could r+ this, in case Nick doesn't mind.

        Attachment #272646 -
        Flags: review+

    
  

        Attachment #272646 -
        Flags: review?(nick.kreeger) → superreview?(mikepinkerton)

    
    

    
  
Comment on attachment 272646 [details] [diff] [review]
fix

rs=pink

        Attachment #272646 -
        Flags: superreview?(mikepinkerton) → superreview+

    
    

    
  
Landed on trunk and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: fixed1.8.1.7
Resolution: --- → FIXED
Target Milestone: --- → Camino1.6

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: