388971 - add unit test to check for R_386_PC32 relocations

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[(not currently active) Ted Mielczarek]

These R_386_PC32 relocations creep into the build when using system headers without adding them to the list in config/system-headers.  This breaks x86_64 builds (with a newer GCC), and it breaks running these builds on an SELinux system.  As a stopgap until we can get an x86_64 tinderbox (bug 359336), bsmedberg suggested a unit test that would check for these sections in our shared libs.  I believe it doesn't have to be any more complicated than:
objdump -R *.so | grep R_386_PC32

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: add a simple unit test

Pretty simple, except for the ugly shell logic.

Comment 2

[Benjamin Smedberg]

Comment on attachment 274377 [details] [diff] [review]
add a simple unit test

1) Do you want to test TARGET_CPU as well?
2) you probably want to quote $$relcount in case objdump exits without any output
3) dist/bin/*.so won't check component DLLs

Comment 3

[(not currently active) Ted Mielczarek]

Given taht bug 359336 is fixed, I'm WONTFIXING.

Comment 4

[Benjamin Smedberg]

Reopening, bug 595112 apparently added a 32-bit only case of this, so we should just check it.

Comment 5

[Benjamin Smedberg]

http://hg.mozilla.org/mozilla-central/rev/b4811d1b1fea

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Was it intentional that the target was 'scheck' rather than 'check'?

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Also, do 'make check' tests run anywhere on tinderbox?  (And would this even pass until bug 604307 is fixed?)

Comment 8

[(not currently active) Ted Mielczarek]

They run after the build on both the opt and debug build machines. (Technically after the build has been uploaded for the test machines to do their thing.)

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Now that bug 604307 is fixed, should this be changed from 'scheck' to 'check'?

Comment 10

[Benjamin Smedberg]

That sounds reasonable, yes.

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://tbpl.mozilla.org/?tree=Try&rev=48e240000c54 with
try: --build do --platform linux,android-x86,linux_gecko --unittests none --talos none --no-emails

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Enable the 'make check' test checking for bad relocations.

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eadaf7446c64

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eadaf7446c64