389507 - ActionMonkey build fails: ‘class MMgc::RCObject’ has no member named ‘DecrementRef’

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Anthony Nemitz]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.5) Gecko/20061201 Firefox/2.0.0.5 (Ubuntu-feisty)
Build Identifier: Trunk

After applying the patch for bug 389443, the build system fails: In destructor ‘MMgc::WriteBarrierRC<T>::~WriteBarrierRC()’:
/home/anemitz/actionmonkey/js/tamarin/MMgc/WriteBarrier.h:150: error: ‘class MMgc::RCObject’ has no member named ‘DecrementRef’


Reproducible: Always

Steps to Reproduce:
1. Apply patch for 389443
2. make -f Makefile.ref 

Actual Results:  
g++ -o MMgc/MMgc.o -DSOFT_ASSERTS  -DDEBUG -D_DEBUG   -fno-exceptions -fno-rtti -Werror -Wall -Wno-reorder -Wno-switch -Wno-invalid-offsetof -fmessage-length=0 -finline-functions -finline-limit=65536  -g    -I/home/anemitz/actionmonkey/js/tamarin -I/home/anemitz/actionmonkey/js/tamarin/MMGC -I/home/anemitz/actionmonkey/js/tamarin/core -I/home/anemitz/actionmonkey/js/tamarin/codegen -I/home/anemitz/actionmonkey/js/tamarin/pcre  -c MMgc/MMgc.ii
/home/anemitz/actionmonkey/js/tamarin/MMgc/WriteBarrier.h: In destructor ‘MMgc::WriteBarrierRC<T>::~WriteBarrierRC()’:
/home/anemitz/actionmonkey/js/tamarin/MMgc/WriteBarrier.h:150: error: ‘class MMgc::RCObject’ has no member named ‘DecrementRef’

Comment 1

[Jason Orendorff [:jorendorff]]

anemitz reports that hacking the Makefile to add -DUNIX -DAVMPLUS_UNIX gets him past this problem.

These flags need to be added in 3 places:

1. js/tamarin/configure.py or one of the python scripts in js/tamarin/build

2. js/src/config/Linux_All.mk (the easy one) - see dup bug 389749 to see why we need to add these flags here as well

3. Makefile.in, for the same reason as #2 (bsmedberg?)

Comment 3

[Anthony Nemitz]

Attachment: js/tamarin/configure.py - added check for linux

Comment 4

[Anthony Nemitz]

Attachment: js/src/config/Linux_All.mk fix - added unix flags

Comment 5

[Jason Orendorff [:jorendorff]]

This is happening again for both Swaroop and Anthony.

Comment 6

[Jason Orendorff [:jorendorff]]

Attachment: trivial fix for linux build

I think a merge from upstream broke this.  The fix is trivial.  Pushed to actionmonkey branch, changeset f851780ab3d8.