389720 - zooming frameset is poor

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Peter van der Woude [:Peter6]]

Attachment: testcase

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007072607 Minefield/3.0a7pre ID:2007072607

repro:
Open FF
install http://ted.mielczarek.org/code/mozilla/fullpagezoom.xpi (pagezoom ext.)
open testcase and zoom in

result:
broken frames

Comment 1

[Peter van der Woude [:Peter6]]

Attachment: testcase including content/scrollbars

testcase including content to show all weirdness.
The scrollbar issues is bug 389659, I don't know if 389659 will fix the odd content selection when you touch the bottom toolbars too.

Comment 3

[Michael Ventnor]

I think the fix here is to use CallChildren just like in text zoom. However, that means that the check for the root PresContext would have to go.

Comment 4

[Eli Friedman]

Attachment: Patch

I think this is the best way to go about fixing this... we have to make sure to run the style change on subdocuments even though the device context thinks nothing has changed.

Comment 5

[Eli Friedman]

Comment on attachment 274544 [details] [diff] [review]
Patch

Low-risk patch; only touches codepath for page zoom.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 274544 [details] [diff] [review]
Patch

a19=dbaron

Comment 7

[(not currently active) Ted Mielczarek]

a) eli is capable of checking in his own bugs
b) we have a checkin-needed keyword now, use that instead

Comment 8

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007080714 Minefield/3.0a8pre ID:2007080714

testcase 2: scrollbars don't appear when zooming in
----------------------------------------------------
more complex case with many frames:
open gmail
zoom in
click on [Sent Mail] link
click on [inbox] link
reset zoom (zoomfactor 1)

result: a part of the content is not painted, a part is painted enlarged, a part is painted correctly.
(a zoom in/out followed by reset zoom fixes the display again)

Comment 9

[Eli Friedman]

Ugh, that's a regression... not frameset-specific, though.  It's a page navigation regression.

Comment 10

[Eli Friedman]

I'll mark this fixed since the patch was checked in... I'll do the regression fixing in other bugs.

Comment 11

[Martijn Wargers (dead)]

I couldn't find a bug about it (although I think it was already filed), but I filed bug 421096 for the frame resizer looking wrong while being zoomed in.