Closed
Bug 389953
Opened 17 years ago
Closed 17 years ago
[BEOS] BeOS should build components with -Bsymbolic
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: thesuckiestemail, Assigned: doug)
Details
(Keywords: verified1.8.1.8)
Attachments
(1 file)
736 bytes,
patch
|
benjamin
:
review+
dveditz
:
approval1.8.1.8+
|
Details | Diff | Splinter Review |
Why: -Bsymbolic causes the linker to resolve as many symbols as possible at link time, so references from a class to its indirection table (for example) are not resolved to a separate shared object. This has the additional advantage of making loading faster. Linux does this already, and now that I tested building with it I want it ASAP.
Comment on attachment 274284 [details] [diff] [review] add -Bsymbolic, and remove weird BeOS-comment (1.8 branch) r? Simple change most other platforms have this so review should be no-brainer. Would like this checked in on 1.8 branch as well as trunk. What needs to be done?
Attachment #274284 -
Flags: review?(benjamin)
Comment 3•17 years ago
|
||
Comment on attachment 274284 [details] [diff] [review] add -Bsymbolic, and remove weird BeOS-comment (1.8 branch) To request approval for the 1.8.1 branch, set "approval1.8.1.7?".
Attachment #274284 -
Flags: review?(benjamin) → review+
Attachment #274284 -
Flags: approval1.8.1.7?
Assignee | ||
Comment 4•17 years ago
|
||
I've successfully applied the patch and built Firefox 2.0.0.7pre (1.8.1.7) and can see no regressions.
Comment 6•17 years ago
|
||
Comment on attachment 274284 [details] [diff] [review] add -Bsymbolic, and remove weird BeOS-comment (1.8 branch) approved for 1.8.1.7, a=dveditz for release-drivers
Attachment #274284 -
Flags: approval1.8.1.7? → approval1.8.1.7+
Assignee | ||
Comment 7•17 years ago
|
||
thank you, Daniel! Sergei, do you have the ability to commit this change?
Comment 8•17 years ago
|
||
Will try ASAP (this weekend probably)
Comment 9•17 years ago
|
||
Checking in mozilla/config/rules.mk; /cvsroot/mozilla/config/rules.mk,v <-- rules.mk new revision: 3.487.2.8; previous revision: 3.487.2.7 done
Updated•17 years ago
|
Keywords: fixed1.8.1.7
QA Contact: build-config → thesuckiestemail
Reporter | ||
Comment 10•17 years ago
|
||
Sergei, was that on trunk? I'd like it in the branch for Firefox 2.0.0.7, so we can release a kick ass version of it :) Can't see it on either branch in LXR yet though...
Comment 11•17 years ago
|
||
2 tqh both checkout and checkin command lines included -r MOZILLA_1_8_BRANCH (though, for ci it is not needed AFAIK after proper co). LXR and anonymous cvs-mirrors may lag. Will see tomorrow, if I made some big mistake or you are bit impatient:)
Assignee | ||
Comment 12•17 years ago
|
||
I updated using the branch tag today - the checkin was in the branch. Thanks, Sergei! tqh, I think you can mark the status as "fixed". Thanks for this great build change.
Reporter | ||
Comment 13•17 years ago
|
||
I think we should land it on trunk as well.
Assignee | ||
Comment 14•17 years ago
|
||
(In reply to comment #13) > I think we should land it on trunk as well. > A good idea, just in case anyone overcomes all the dependency problems and manages to get a working trunk build someday.
Comment 15•17 years ago
|
||
tqh, can you help us verify this fix in FF 2008rc2?
Assignee | ||
Comment 16•17 years ago
|
||
(In reply to comment #15) > tqh, can you help us verify this fix in FF 2008rc2? > I can verify the fix is in 2.0.0.8 and working. Thanks, juan!
Assignee: nobody → doug
Status: ASSIGNED → NEW
Assignee | ||
Updated•17 years ago
|
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Comment 17•17 years ago
|
||
Thanks Doug. Changing keyword to verified1.8.1.8
Keywords: fixed1.8.1.8 → verified1.8.1.8
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•