390185 - signtool error message wrongly uses the term "database"

Status: RESOLVED FIXED

(NSS :: Tools, defect, P3)

Description

[Nelson Bolyard (seldom reads bugmail)]

In signtool's function 
if the call to 
fails for any reason, signtool outputs the error message 
    "the cert \"%s\" does not exist in the database"
                                    ^^^^^^^^^^^^^^^
This is misleading, because it may not have looked "in the database"
AT ALL.  The phrase "in the database" should be removed.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Correction:
In signtool's function create_pk7, if the call to PK11_FindCertFromNickname
fails for any reason ...

See http://lxr.mozilla.org/security/source/security/nss/cmd/signtool/sign.c#270

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch v1

This should do it

Comment 3

[Neil Williams]

Comment on attachment 274528 [details] [diff] [review]
patch v1

r+

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Checking in cmd/signtool/sign.c; new revision: 1.13; previous revision: 1.12