390188 - PK11_FindCertFromNickname should find nicknames with colons in certDB

Status: RESOLVED WONTFIX

(NSS :: Libraries, defect, P2)

Description

[Nelson Bolyard (seldom reads bugmail)]

When PK11_FindCertFromNickname is called with a nickname with a colon in it,
it tries to find a token with the name before the colon, and if that fails,
it gives up.  It should attempt to retry the operation, looking for the whole
original nickname string in the softoken.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch v1

This patch is mutually exclusive with the patch attached to bug 390187.
One of these bugs should be marked WONTFIX, I think.
Please vote for one.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch v2, fix both functions

There are two functions in this source file that both have the same problem.
This patch fixes them both.

Comment 3

[Julien Pierre]

I prefer to fix bug 390187 rather than this one. It has always been the case that the string before the first colon signifies the token in nicknames. Let's not try to change it. As you pointed out, the problem can be worked around by prefixing the softoken token name.

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

OK, Julien and Bob both voted for the other bug/fix.  so, WONTFIX

Comment 5

[Neil Williams]

Comment on attachment 274557 [details] [diff] [review]
patch v2, fix both functions

cancelling reqview request