390468 - The XUL toolbar's "mode" attribute is not functional

Status: UNCONFIRMED

(Toolkit :: UI Widgets, defect)

Description

[Emery]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070725 Firefox/2.0.0.6
Build Identifier: 

The "mode" attribute described in http://developer.mozilla.org/en/docs/XUL:toolbar does not function because the styles do not exist in the global skin.

Reproducible: Always

Comment 1

[Emery]

Attachment: Moves the styles for "mode" to a location where they won't be overridden.

This patch should fix it in all themes.

Comment 2

[Emery]

Attachment: Fixes a small mistake in the previous patch

I accidentally left a line removal in the previous patch that doesn't apply to the bug. Sorry about that.

Comment 3

[Alex Vincent [:WeirdAl]]

Emery, is this patch ready for reviews?  If so, may I suggest mconnor or neil@parkway?

Comment 4

[Emery]

Neil looked at it before and, IIRC, although the patch is good and those style rules do just need to be in toolbarbutton.css instead of toolbar.css to avoid being overridden, he noticed some nasty workarounds wherein toolbar.css is imported after the global skin, effectively re-overriding the overridden styles. And he told me that I should remove all of those imports while I'm at it, making sure that it doesn't break Thunderbird which happens to be affected. I'll make the changes and ask Neil to review it again. Thanks for the reminder Alex.