390711 - autocomplete dropdown has no border after 388317

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P3)

Description

[logan]

On gtk builds, the autocomplete dropdown is just plain white (no border). This blends into the background of most pages and generally looks bad. As stated in comment 5 of 388317, a "border: 1px solid black;" would take care of this.

Comment 1

[Sylvain Pasche]

Attachment: testcase

Comment 2

[Sylvain Pasche]

Attachment: Linux screenshot

Comment 3

[Sylvain Pasche]

Attachment: Windows XP screenshot

Comment 4

[Sylvain Pasche]

The modification made in bug 388317 for the menulist does not apply on Linux, as the Linux theme has its own popup.css file. But for autocomplete.css, it is shared between between the two.

I see two options for fixing the Linux case:
1) Keep the old -moz-appearance for linux in gnomestripe
2) Fix the CSS on Linux to have the popup looks native (not sure why background-color: -moz-field and ThreeDDarkShadow do not look native).

Comment 8

[jigar shah]

Is these two bugs are related 
https://bugzilla.mozilla.org/show_bug.cgi?id=392655

Anyone has filed a bug with gtk team ?

Comment 9

[Elmar Ludwig]

(In reply to comment #8)
> Is these two bugs are related

No.

Comment 13

[Damon Sicore (:damons)]

+'ing.  Setting priority to P3.

Comment 14

[Sylvain Pasche]

Attachment: patch, v1

Well, ifdefs are bad, but this makes both panel and panel[type="autocomplete"] have a -moz-appearance set to menupopup on GTK (so they will have borders).
After bug 388317, panel and panel[type="autocomplete"] had their -moz-appearance set to menupopup and none respectively (see comment 4).

Comment 15

[Asaf Romano (gone)]

Comment on attachment 288230 [details] [diff] [review]
patch, v1

Neil should review this.

Comment 16

[[e-mail]]

Comment on attachment 288230 [details] [diff] [review]
patch, v1

I hope Mano means the other Neil.

Comment 17

[Reed Loden [:reed]]

Checking in toolkit/themes/winstripe/global/autocomplete.css;
/cvsroot/mozilla/toolkit/themes/winstripe/global/autocomplete.css,v  <--  autocomplete.css
new revision: 1.20; previous revision: 1.19
done
Checking in toolkit/themes/winstripe/global/jar.mn;
/cvsroot/mozilla/toolkit/themes/winstripe/global/jar.mn,v  <--  jar.mn
new revision: 1.38; previous revision: 1.37
done

Comment 18

[Daniel Holbert [:dholbert]]

Pretty sure this bug's patch caused a regression.  

There's now a weird gray bar at the top of the dropdown, which pushes the last (or only) completion in the box out of view. See bug 403659 and the screenshots posted there.

Comment 19

[Sylvain Pasche]

(In reply to comment #18)
> Pretty sure this bug's patch caused a regression.  
> 
> There's now a weird gray bar at the top of the dropdown, which pushes the last
> (or only) completion in the box out of view. See bug 403659 and the screenshots
> posted there.

-> regression of bug 118312

Comment 22

[Carsten Book [:Tomcat]]

verified fixed using Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b2) Gecko/2007121016 Firefox/3.0b2Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b2) Gecko/2007121016 Firefox/3.0b2 on Fedora F8 by using the testcase from this bug and also testing the automcomplete dropdown.

-> Verified fixed