390841 - Open links in Litmus testcases in a new window.

Status: VERIFIED FIXED

(Webtools Graveyard :: Litmus, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Summary: Open links in Litmus testcases in a new window.

Steps to Reproduce:

1. Load a litmus testcase that instructs you to click on a link.
2. Click on said link.

Expected Results:

Link opens in a new window.

Actual Results:

Link opens in the currently viewed Litmus testcase window.

I'm still trying to figure out what I can bribe Zach with.  (Cheap) suggestions welcome!

Comment 1

[Zach Lipton [:zach]]

Attachment: Add target="blank" to testdata links

So this is a patch that sneaks target="blank" into links in testdata fields (steps to reproduce and expected results). It's somewhat ugly (it's literally just a regexp replace on "<a"), so I'm not entirely sure that this is what we want to be doing here, but short of an html parser, it's a working solution. Coop: are you ok with this?

stephend: I'm going out on a limb here and working on this without a firm idea of what my bribe will be. Don't let me down here...

Comment 2

[Chris Cooper [:coop] (he/him)]

Comment on attachment 276689 [details] [diff] [review]
Add target="blank" to testdata links

I might select a different name for the window ("externallink" ?), but otherwise it looks good.

Comment 3

[Zach Lipton [:zach]]

fix checked in

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED--I just checked this on Firefox 2.0.0.6 on Mac OS X 10.4 and it worked.

Thanks for fixing this; bribe-planning is underway...