390858 - Update FAMO and AMO

Status: VERIFIED FIXED

(Infrastructure & Operations Graveyard :: WebOps: Other, task)

Description

[Justin Scott [:fligtar]]

Please svn up both AMO and FAMO for a couple updates to the Facebook app.

Comment 1

[Justin Fitzhugh]

cbeard = ? (he's asked to approve pushes)

Comment 2

[Chris Beard]

what are the updates?  has QA signed off? (to revalidate that the changes introduced do not break anything in the test matrix)

Comment 3

[Justin Scott [:fligtar]]

The changes are here: http://viewvc.svn.mozilla.org/vc?view=rev&revision=5507

They are just adding a page with the RYF wallpaper (http://apps.facebook.com/add-ons-staging/wallpaper) that we were going to link folks to and an update notes page (http://apps.facebook.com/add-ons-staging/updatenotes).

QA has not signed off, although I don't think the full test suite needs to be run to add the 2 pages as I am very confident they will not break existing functionality.

All the bugs and changes are taking place in the addons.mozilla.org :: Facebook Application component of Bugzilla.

I didn't know the update process would be like this; I guess we need a better process.

Comment 4

[Chris Beard]

sounds reasonable -- as you know, we went through a QA validation process to ensure that this app was ready for production.  we should not invalidate that, and ensure that we get sign off before pushing things live, otherwise we may inadvertently break things or people.  

in this case, describing what the changes are, and your feeling for risk to the app is super useful.  this doesn't mean that we need to re-run the whole test suite for each change, but we do need a process for getting all the stakeholders to sign off or agree that a certain class of changes should just happen (e.g. string changes vs. adding or changing functionality)

Comment 5

[Justin Scott [:fligtar]]

Yes, I agree. I just meant we need a better process for requesting QA support or signoff than in an IT bug.

Webdev isn't used to that, so we are having to figure out how it should work, which is a good thing.

Comment 6

[matthew zeier [:mrz]]

So this is okay to go, right?  I can push out the changes?

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

What should I test, exactly?  The two staging URLs in comment 3, at the very least on the 90% coverage Windows XP SP2 platform?

Is this sufficient?  A run-through of my whole testcases takes 2-3 hours...

Comment 8

[Chris Beard]

(In reply to comment #7)
> What should I test, exactly?  The two staging URLs in comment 3, at the very
> least on the 90% coverage Windows XP SP2 platform?
>
> Is this sufficient?  A run-through of my whole testcases takes 2-3 hours...

Yes.  It doesn't sound like these are very risky changes at all.  a=cbeard, once we've validated that there isn't a breakage or a significant chance of one on the staging server.

(FYI, Morgamic and I are talking about how to extend or refine a process for this sort of thing that makes sense.)

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Here's what I've run from the QA standpoint.

I ran a subset of my Litmus testcases (http://litmus.mozilla.org/show_test.cgi?searchType=by_category&product_id=6&branch_id=16&testgroup_id=62&subgroup_id=824) against Firefox 2.0.0.6 of Windows XP SP2, on the staging instance at http://apps.facebook.com/add-ons-staging (including the two URLs, again, mentioned in comment 3).

On the wallpaper link, I tested that the wallpaper images:
A) Loaded
B) Were the right dimensions--and filled the screen accordingly, naturally

From my perspective and understanding of the changes here, you have official QA sign-of from me.

Let me know ASAP if you need more...thanks!

Comment 10

[Reed Loden [:reed]]

With cbeard's approval and QA's sign-off, taking this as OK to update.

[root@mradm01 addons.mozilla.org-remora]# svn up
 U   .

Fetching external item into 'site'
A    site/app/locale/ko/pages/nomination.thtml
A    site/app/locale/ko/pages/developer_agreement.thtml
U    site/app/locale/ko/pages/sandbox.thtml
A    site/app/locale/ko/pages/policy.thtml
U    site/app/locale/ko/LC_MESSAGES/messages.mo
U    site/app/locale/ko/LC_MESSAGES/messages.po
A    site/app/webroot/img/facebook/wallpaper
A    site/app/webroot/img/facebook/wallpaper/rock_firefox_1024x768.jpg
A    site/app/webroot/img/facebook/wallpaper/rock_firefox_800x600.jpg
A    site/app/webroot/img/facebook/wallpaper/rock_firefox_preview.png
A    site/app/webroot/img/facebook/wallpaper/rock_firefox_1920x1200.jpg
A    site/app/webroot/img/facebook/wallpaper/rock_firefox_1280x1024.jpg
A    site/app/webroot/img/facebook/wallpaper/rock_firefox_1440x900.jpg
A    site/app/webroot/img/facebook/wallpaper/rock_firefox_1680x1050.jpg
U    site/app/controllers/facebook_controller.php
U    site/app/views/layouts/facebook.thtml
A    site/app/views/facebook/admin.thtml
U    site/app/views/facebook/view.thtml
A    site/app/views/facebook/updatenotes.thtml
U    site/app/views/facebook/share.thtml
U    site/app/views/facebook/outage.thtml
A    site/app/views/facebook/wallpaper.thtml
Updated external to revision 5507.


Fetching external item into 'bin'
A    bin/download_count.php
Updated external to revision 5507.

Updated to revision 5529.

[root@mradm01 facebook.addons.mozilla.org]# svn up
 U   .

Fetching external item into 'site'
A    site/app/webroot/img/facebook/wallpaper
A    site/app/webroot/img/facebook/wallpaper/rock_firefox_1024x768.jpg
A    site/app/webroot/img/facebook/wallpaper/rock_firefox_800x600.jpg
A    site/app/webroot/img/facebook/wallpaper/rock_firefox_preview.png
A    site/app/webroot/img/facebook/wallpaper/rock_firefox_1920x1200.jpg
A    site/app/webroot/img/facebook/wallpaper/rock_firefox_1280x1024.jpg
A    site/app/webroot/img/facebook/wallpaper/rock_firefox_1440x900.jpg
A    site/app/webroot/img/facebook/wallpaper/rock_firefox_1680x1050.jpg
U    site/app/controllers/facebook_controller.php
U    site/app/views/facebook/admin.thtml
A    site/app/views/facebook/updatenotes.thtml
A    site/app/views/facebook/wallpaper.thtml
Updated external to revision 5507.

Updated to revision 5529.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified; been in production with no issues for a while now.