391037 - move about:config "i'll be careful" button alignment/packing into theme

Status: RESOLVED INCOMPLETE

(Firefox :: General, defect)

Description

[mcdavis941 (sporadically reading bugmail)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070725 Firefox/2.0.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007080309 Minefield/3.0a8pre

The XUL for the about:config window's "i'll be careful" button defines positioning for the button as centered with pack="center" on the buttons container in the XUL.   

For the benefit of theme authors who want a different positioning, move the positioning into the theme and out of the XUL by removing the pack="center" from the XUL and adding a rule setting -moz-box-pack: center in the relevant theme CSS.

(Left-aligned would be consistent with the position of the button on other Firefox error pages displayed with netError.xhtml, which also put the button on the left.  Also, in my opinion, positioning the button left-aligned gives better eye-flow and layout.)


Reproducible: Always

Comment 1

[mcdavis941 (sporadically reading bugmail)]

Attachment: moves packing out of XUL and into theme

This patches config.xul and four themes to get the same effect using CSS as currently achieved with XUL alone.  Tested on WinXP -- someone else would have to verify on other platforms.

Comment 2

[Tyler Downer [He/Him]]

Reporter, are you still seeing this issue with Firefox 3.6.8 or later in safe mode? If not, please close. These links can help you in your testing.
http://support.mozilla.com/kb/Safe+Mode
http://support.mozilla.com/kb/Managing+profiles

Comment 3

[mcdavis941 (sporadically reading bugmail)]

(In reply to comment #2)
> Reporter, are you still seeing this issue with Firefox 3.6.8 or later in safe
> mode?

Not that I'm saying this is an important bug, but yes.

The issue could also be restated as not conforming to convention for position of buttons within about: pages.  If you compare with similar pages (about:neterror, about:privatebrowsing, about:sessionrestore, about:certerror, about:blocked) none of them use a centered button placement.

Comment 4

[mcdavis941 (sporadically reading bugmail)]

As far as XUL attribute vs. equivalent CSS property, common practice seems to be to take it as an XUL attribute when it involves layout, although I'm not aware of a strong argument for doing it one way or the other.

Either way, the reason I wanted position moved into the theme is so that I could correct it for myself in my own third-party theme.  If position were standardized in XUL source, I wouldn't need it moved into theme CSS any more.

Comment 5

[Tyler Downer [He/Him]]

No reply, INCOMPLETE. Please retest with Firefox 3.6.10 or later and a new profile (http://support.mozilla.com/kb/Managing+profiles). If you continue to see this issue with the newest firefox and a new profile, then please comment on this bug.