Closed Bug 391359 Opened 17 years ago Closed 17 years ago

update to breakpad revision 198

Categories

(Toolkit :: Crash Reporting, defect)

Product:
Toolkit
Component:
Crash Reporting
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: alfred.peng, Assigned: alfred.peng)

References

Details

Attachments

(2 files)

sync to revision 198
84.92 KB, patch
ted
: review+
Details | Diff | Splinter Review
revised patch without "Makefile"
81.77 KB, patch
Details | Diff | Splinter Review 
Sync us up to Breakpad r198, which includes the Solaris port of breakpad client.
Besides the Solaris port, also contain the following two issues:
1. Fix permissions on dump file in MinidumpFileWriter.
2. Crash when processing file names less than 4 bytes.
Attachment #275773 - Flags: review?(ted.mielczarek)
Comment on attachment 275773 [details] [diff] [review]
sync to revision 198

Pretty harmless, except for the Solaris code, there aren't any major changes in here.  I do want to get bug 389548 landed first though, to stop using toolkit/airbag.
Attachment #275773 - Flags: review?(ted.mielczarek) → review+
Almost forgot, when we land this we don't want to add
src/client/solaris/handler/Makefile

Makefiles just get in the way of our build system, so we haven't been importing them to CVS.

luser, I notice that bug 389548 has been landed. Any other approvals I need to get before checking in this patch?
No, I think you're ok, once the tree is green.  :)  Just remember you'll have to CVS add all the new files (but please leave out that Makefile).
Status: NEW → ASSIGNED
Assignee: nobody → alfred.peng
Status: ASSIGNED → NEW
Patch checked in.

=>FIXED.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: