391856 - button-images are outside the button and squeezed (new DM)

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Peter van der Woude [:Peter6]]

Attachment: screenshot

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007081115 Minefield/3.0a8pre ID:2007081115

Comment 1

[Steve England [:stevee]]

I am guessing this is also causing there to be a horizontal scrollbar when there is no need for one (changing the DM window to any size and the horiz scrollbar is always present)

Comment 2

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Patch

Fixes the padding/margin issues and moves all button styling to a new mini-button class - which I'll switch pinstripe over to in another bug.

Comment 3

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Comparison shot

Comment 4

[Shawn Wilsher :sdwilsh]

Comment on attachment 276325 [details] [diff] [review]
Patch

Looks good to me.  Just checking to make sure that some of those lines don't wrap more than 80 characters.

I'd also like Mano to look at this because he's the CSS wizard.

Comment 5

[Shawn Wilsher :sdwilsh]

Comment on attachment 276326 [details]
Comparison shot

This looks much better - although the pop-up doesn't look quite right still :/ (not this bug, clearly)

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 276325 [details] [diff] [review]
Patch

r=me (fast pass so we can get it into nightlies, hopefully Mano can look a little closer)

Comment 7

[Ryan Flint [:rflint] (ping via IRC for reviews)]

mozilla/toolkit/mozapps/downloads/content/download.xml           1.30 mozilla/toolkit/mozapps/downloads/content/downloads.xul 	 1.25
mozilla/toolkit/themes/winstripe/mozapps/downloads/downloads.css 1.16

Comment 8

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007081201 Minefield/3.0a8pre ID:2007081201

VERIFIED

Comment 9

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Clean up

Comment 10

[Asaf Romano (gone)]

Comment on attachment 276363 [details] [diff] [review]
Clean up

r=mano

Comment 11

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Comment on attachment 276363 [details] [diff] [review]
Clean up

mozilla/toolkit/themes/winstripe/mozapps/downloads/downloads.css 	1.18