Closed
Bug 392060
Opened 17 years ago
Closed 15 years ago
snav crashed with dynamic/multant DOM contents
Categories
(Core :: DOM: UI Events & Focus Handling, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: tonikitoo, Unassigned)
References
()
Details
Attachments
(3 files, 2 obsolete files)
153.38 KB,
image/jpeg
|
Details | |
6.55 KB,
patch
|
dougt
:
review-
|
Details | Diff | Splinter Review |
6.18 KB,
patch
|
dougt
:
review-
|
Details | Diff | Splinter Review |
PRECONDITIONS: firefox 2 built with 'spatialnavigation' extension enabled. mozconfig: _________________________________________ mk_add_options MOZ_CO_PROJECT=browser ac_add_options --enable-application=browser ac_add_options --enable-extensions=spatialnavigation ac_add_options --disable-airbag _________________________________________ STEPS LEADING TO PROBLEM: 1. go to 'www.aol.com' 2. Using snav (or not), focus highlight any link in the "featured stories" box near the center/top of the page (see attachment). 2.1 Note that the contents of this box rotates over time. Allow it to rotate to another content item. 3. Press a navigation key EXPECTED OUTCOME: browser does not crash ACTUAL OUTCOME: FF2 crashes FREQUENCY OF OCCURRENCE: always
Flags: in-testsuite?
Reporter | ||
Comment 1•17 years ago
|
||
well ... see frame where crash occurs. btw, firefox 2 (and also 3) renders this webpage badly, so I sshot'ed it with opera :/
Attachment #276498 -
Flags: review?
Reporter | ||
Comment 2•17 years ago
|
||
Attachment #276499 -
Flags: review?(dougt)
Reporter | ||
Updated•17 years ago
|
Attachment #276498 -
Flags: review?
Updated•17 years ago
|
Attachment #276499 -
Flags: review?(dougt) → review+
Reporter | ||
Comment 3•17 years ago
|
||
doug could you check this in ?
Assignee: tonikitoo → dougt
Keywords: checkin-needed
Comment 4•17 years ago
|
||
sure, i can. The patch above is for the 1.8 branch. Can you put together a trunk patch really quick and I will land both at the same time.
Updated•17 years ago
|
Component: Keyboard Navigation → Keyboard: Navigation
Product: Firefox → Core
QA Contact: keyboard.navigation → keyboard.navigation
Version: 2.0 Branch → Trunk
Reporter | ||
Comment 5•17 years ago
|
||
I added some further NULL point checks
Attachment #276499 -
Attachment is obsolete: true
Reporter | ||
Comment 6•17 years ago
|
||
removed wrongly "tab"
Attachment #277236 -
Attachment is obsolete: true
Attachment #277238 -
Flags: review?(dougt)
Reporter | ||
Comment 7•17 years ago
|
||
snav still fails to build in FF3/trunk (with or without this patch applied) due to bug 347731, however the changes proposed in this patch do not affect it at all, and it can be committed.
Attachment #277240 -
Flags: review?(dougt)
Comment 8•17 years ago
|
||
I am not sure it is a good idea to land anything on something that can't compile and sort of don't want to have the code diverge. Let me go over and comment on 347731.
Updated•17 years ago
|
Keywords: checkin-needed
Comment 10•16 years ago
|
||
Comment on attachment 277238 [details] [diff] [review] patch adds some needed NULL point checks into snav source (v3) i no longer support extensions/spatialnavigation. I rewrote this feature set in js and that is what I am currently using.
Attachment #277238 -
Flags: review?(doug.turner) → review-
Updated•16 years ago
|
Attachment #277240 -
Flags: review?(doug.turner) → review-
Comment 11•15 years ago
|
||
The code has been rewritten in JS. The C++ version is no longer in the repo.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → WORKSFORME
Assignee | ||
Updated•5 years ago
|
Component: Keyboard: Navigation → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•