Closed
Bug 392657
Opened 17 years ago
Closed 17 years ago
"ASSERTION: QueryInterface needed", nsURIChecker missing nsIRequestObserver in QI map
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bent.mozilla, Assigned: bent.mozilla)
Details
Attachments
(1 file, 1 obsolete file)
|
2.52 KB,
patch
|
Biesinger
:
review+
Biesinger
:
superreview+
bzbarsky
:
approval1.9+
|
Details | Diff | Splinter Review |
Seems that NS_NewRequestObserverProxy isn't properly QI'ing its result. Patch attached.
Attachment #277151 -
Flags: superreview?(cbiesinger)
Attachment #277151 -
Flags: review?(cbiesinger)
|
Assignee | |
Comment 1•17 years ago
|
||
Comment on attachment 277151 [details] [diff] [review] Patch The problem is deeper than I thought. New patch in a sec.
Attachment #277151 -
Attachment is obsolete: true
Attachment #277151 -
Flags: superreview?(cbiesinger)
Attachment #277151 -
Flags: review?(cbiesinger)
|
|
Assignee | |
Comment 2•17 years ago
|
||
Ok, looks like nsIRequestObserver wasn't in the QI map.
Assignee: nobody → bent.mozilla
Status: NEW → ASSIGNED
Attachment #277309 -
Flags: superreview?(cbiesinger)
Attachment #277309 -
Flags: review?(cbiesinger)
|
||
Comment 3•17 years ago
|
||
Comment on attachment 277309 [details] [diff] [review] Patch oh, good catch!
Attachment #277309 -
Flags: superreview?(cbiesinger)
Attachment #277309 -
Flags: superreview+
Attachment #277309 -
Flags: review?(cbiesinger)
Attachment #277309 -
Flags: review+
|
|
Assignee | |
Updated•17 years ago
|
Attachment #277309 -
Flags: approval1.9?
|
|
Assignee | |
Updated•17 years ago
|
Summary: "ASSERTION: QueryInterface needed" in nsRequestObserverProxy → "ASSERTION: QueryInterface needed", nsURIChecker missing nsIRequestObserver in QI map
|
||
Comment 4•17 years ago
|
||
Comment on attachment 277309 [details] [diff] [review] Patch a=bzbarsky
Attachment #277309 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 5•17 years ago
|
||
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•