39294 - CElement::GetElement used before definition

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect, P3)

Description

[tor]

CElement::GetElement() (in COtherElements.h) is being used before the
definition as "inline", which causes the SUNWspro4.2 compiler to choke.
I'm planning on checking in the following patch (reviewed by bruce)
when the tree opens.  This just moves GetElement up before any of the
inline functions.

If this offends your coding aesthetics, let me know.  Otherwise I'll
close this bug after checking in this fix.

Index: COtherElements.h
===================================================================
RCS file: /cvsroot/mozilla/htmlparser/src/COtherElements.h,v
retrieving revision 3.17
diff -u -r3.17 COtherElements.h
--- COtherElements.h    2000/05/15 07:58:53     3.17
+++ COtherElements.h    2000/05/15 16:58:51
@@ -1917,6 +1917,12 @@
 static eHTMLTags kObjectKids[]={eHTMLTag_param,eHTMLTag_unknown};
 static eHTMLTags kTBodyKids[]={eHTMLTag_tr,eHTMLTag_unknown};
 
+
+inline CElement* CElement::GetElement(eHTMLTags aTag) {
+  return gElementTable->mElements[aTag];
+}
+
+
 /******************************************************************************
*****
   This method is pretty interesting, because it's where the elements all get 
   initialized for this elementtable.
@@ -2550,11 +2556,6 @@
   }
   return 0;
 }
-
-inline CElement* CElement::GetElement(eHTMLTags aTag) {
-  return gElementTable->mElements[aTag];
-}
-
 
 inline CElement* CElement::GetDefaultContainerFor(CElement* anElement) {
   CElement* result=0;

Comment 1

[tor]

Checked in.

Comment 2

[Jan Carpenter]

changing qa contact for solaris bugs to hong