392979 - Loading about:plugins after loading Flash-using sites makes "Shockwave" plugin appear above "Default Plug-in"

Status: VERIFIED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Build ID: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007081704 Minefield/3.0a8pre

Summary: Loading about:plugins after loading Flash-using sites makes "Shockwave" plugin appear above "Default Plug-in".

From my testing on Windows, this appears to be *Mac-only*, until I can prove otherwise.

Steps to Reproduce:

1. Load www.pandora.com and log in (music will play automatically)
2. Command-T, and in the new tab, load about:plugins
3. Switch back to the tab with www.pandora.com
4. Invoke Tools | Add-ons
5. Notice the sort order

Actual Results:

"Shockwave Flash" comes before "Default Plug-in"

Expected Results:

"Default Plug-in"--or whatever you have that's higher up in the alphabet--should be at the top

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of plugin manager tab

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of about:plugins

Oddly enough (or maybe not), both are out-of-sync; do they share codepaths?  i.e. does one affect the other?  I know that about:plugins does a refresh() call, but I can't remember if it's similar to the navigator.plugins.refresh(true) call.

Comment 3

[Robert Strong (they/them - no direct email)]

I'd be interested in seeing the pluginreg.dat (located in your profile directory) as requested in bug 391754.

Also, with the add-ons mgr opened to the plugins view open DOMi and edit the name property of Shockwave Flash. Copy the name and surround the entire value with quotes when you paste it into this bug so we can see if they are prepending it with a space.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: pluginreg.dat

Comment 5

[Robert Strong (they/them - no direct email)]

What is the sort order if you restart and open the add-ons mgr?

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #5)
> What is the sort order if you restart and open the add-ons mgr?

It fixes itself; this is an edge case if I've ever seen one :-(

Also, I don't know how to get domi working on trunk (I'll investigate). 

Comment 7

[Robert Strong (they/them - no direct email)]

So it displays properly then without opening about:plugins. How about when you close and reopen the add-ons mgr?

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #7)
> So it displays properly then without opening about:plugins. How about when you
> close and reopen the add-ons mgr?

That still displays the bug, once triggered. 

Comment 9

[Robert Strong (they/them - no direct email)]

If about:plugins triggers the bug and it displays it properly without opening about:plugins this is likely a bug with about:plugins. If so, the component should be Toolkit -> XUL Widgets.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Having a hard time reproducing now; Rob, should I leave this open and redirect to Toolkit -> XUL Widgets, or just leave it here?  (Can't get it to do what you're asking for in comment 9 ATM.)

Comment 11

[Robert Strong (they/them - no direct email)]

Stephen, just for clarification...

1. Does it display correctly in the add-ons mgr if you start Firefox and open the add-ons mgr without opening about:plugins?

2. Does it only display in the incorrect order in the add-ons mgr if you start Firefox, open about:plugins, and then open the add-ons mgr?

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #11)
> Stephen, just for clarification...
> 
> 1. Does it display correctly in the add-ons mgr if you start Firefox and open
> the add-ons mgr without opening about:plugins?

Yes; I've never had that exhibit the bug.
 
> 2. Does it only display in the incorrect order in the add-ons mgr if you start
> Firefox, open about:plugins, and then open the add-ons mgr?

When I was able to reproduce the bug, yes, this was the way that I triggered it.  I just tried again on the same profile with Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007082604 Minefield/3.0a8pre and can't reproduce it.

Should we leave this open, or mark it as "INCOMPLETE"?  I'm tempted to leave it open so that if anyone else finds a better repro case they can easily find it.

Comment 13

[Robert Strong (they/them - no direct email)]

I'm fine leaving it open. Perhaps during one of the QA days this could be explicitly called out?

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #13)
> I'm fine leaving it open. Perhaps during one of the QA days this could be
> explicitly called out?

Will do! 

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We don't ship a default plugin anymore since Firefox 4. So this flip only happened with the default plugin available? Or were other plugins also affected? If not we should close this bug.

Comment 16

[Dave Townsend [:mossop]]

I just followed the STR and can no longer reproduce this so I think it got fixed somewhere along the way.

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Stephen, have you only seen this with the default plugin or were also other plugins involved?

Comment 18

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #17)
> Stephen, have you only seen this with the default plugin or were also other
> plugins involved?

Just from comment 0.  Can't reproduce it any longer either.

Verified WFM.