393207 - Vercheck failed in JES5 branch.

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P1)

Description

[Slavomir Katuscak]

From comment in vercheck.c:
Any release is incompatible with future releases and patches.

There was NSPR updated from 4.6.7 to 4.6.8 Beta.
4.6.8 is detected as compatible with 4.6.8 Beta, which caused test failure.
The question if this detected compatibility is OK or not (is this future release ??). 

If they should be detected as compatible, 4.6.8 should be replaced in incompatible versions list with 4.6.9. 
If they should be detected as incompatible, problem is in function PR_VersionCheck() and should be fixed there.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

What error string(s) were reported by the test program?

Comment 2

[Christophe Ravel]

BEGIN TEST: vercheck

Should be incompatible with version 4.6.8
NSPR release 4.6.8 Beta:
Compatible with version 4.0
Compatible with version 4.0.1
Compatible with version 4.1
Compatible with version 4.1.1
Compatible with version 4.1.2
Compatible with version 4.1.3
Compatible with version 4.2
Compatible with version 4.2.1
Compatible with version 4.2.2
Compatible with version 4.3
Compatible with version 4.4
Compatible with version 4.4.1
Compatible with version 4.5
Compatible with version 4.5.1
Compatible with version 4.6
Compatible with version 4.6.1
Compatible with version 4.6.2
Compatible with version 4.6.3
Compatible with version 4.6.4
Compatible with version 4.6.5
Compatible with version 4.6.6
Compatible with version 4.6.7
Compatible with version 4.6.8 Beta
Incompatible with version 2.1 19980529
Incompatible with version 3.0
Incompatible with version 3.0.1
Incompatible with version 3.1
Incompatible with version 3.1.1
Incompatible with version 3.1.2
Incompatible with version 3.1.3
Incompatible with version 3.5
Incompatible with version 3.5.1

END TEST: vercheck

Comment 3

[Christophe Ravel]

Summary output:

NSPR Test Results - tests

BEGIN			Tue Aug 21 21:50:12 PDT 2007
NSPR_TEST_LOGFILE	/share/builds/mccrel3/security/securityjes5/builds/20070821.1/biarritz_Solaris10_amd64/mozilla/tests_results/nspr/biarritz.1-SunOS5.8_i86pc_DBG.OBJ-

Test			Result

accept			Passed
acceptread			Passed

<...>

tpd			Passed
udpsrv			Passed
vercheck			FAILED
version			Passed
writev			Passed
xnotify			Passed
zerolen			Passed
END			Tue Aug 21 22:04:39 PDT 2007

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

The output in comment 2 appears to be incomplete, lacking the output that
was printed to stderr.  

In the array of "incompatible_version", change "4.6.8" to "4.6.99"

Comment 5

[Slavomir Katuscak]

Nelson, are you sure you want change to 4.6.99 and no to 4.6.9 ? I checked previous changes in CVS and it was always increased by 1. 

Will I need 2 reviews for this change ? 

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

Slavo, yes 4.6.99
For NSPR, if you get one review from one of the "module owners", 
you won't need a second review (unless the owner who does the first
review asks for a second one).  Basically, you always need one review
from a module owner.

Comment 7

[Slavomir Katuscak]

Attachment: Patch v1.

Comment 8

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 279099 [details] [diff] [review]
Patch v1.

r=nelson

Comment 9

[Slavomir Katuscak]

Checking in vercheck.c;
/cvsroot/mozilla/nsprpub/pr/tests/vercheck.c,v  <--  vercheck.c
new revision: 1.19.2.8; previous revision: 1.19.2.7
done

Comment 10

[Wan-Teh Chang]

I usually increase the incompatible version by 1 to test boundary
conditions.  It's not that important.  So let's take care of this
when we change the NSPR version to 4.6.9 Beta.

Comment 11

[Christophe Ravel]

(In reply to comment #10)
Do you mean that we should replace the current 4.6.99 in the list of the incompatible versions with 4.6.10 when we change the NSPR version to 4.6.9 Beta ?

And that we should have put 4.6.9 as the incompatible version while we were building 4.6.8 ?

Comment 12

[Wan-Teh Chang]

Yes.  But this is a very minor issue, so don't worry about this for
the NSPR 4.6.8 release build.  You can leave 4.6.99 there.

Comment 13

[Nelson Bolyard (seldom reads bugmail)]

I chose 4.6.99 because I don't have the time or inclination to make that
change before/after every release.  If someone is willing to take on that 
duty to change it for every release, then that person can change it to 
4.6.9 (or whatever) and then plan to do that for every release thereafter.
Unless that person is willing to commit to making that change for every 
release, then it should stay at 4.6.99.

Comment 14

[Christophe Ravel]

I can do that.

Here is the list of files that I modify when the version for NSPR is changed:
mozilla/nsprpub/admin/repackage.sh
mozilla/nsprpub/pr/include/prinit.h
mozilla/nsprpub/configure
mozilla/nsprpub/configure.in
mozilla/nsprpub/pr/tests/vercheck.c