393252 - make PerfConfigurator.py support linux and mac

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[[e-mail] (:bhearsum)]

Right now PerfConfigurator.py only runs on Windows. It needs to run on Linux and Mac, too.

I'll be posting a patch that does this in the next day or so. It will also include some bugfixes and cleanup.

Comment 1

[[e-mail] (:bhearsum)]

Looks like this is working well. I still need to test it a bit more on Mac, but I don't expect any problems.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: PerfConfigurator with linux/mac support

This version of PerfConfigurator runs cleanly on Mac and Linux. The only thing that needs to be adjusted is the masterIniSubpath, if the BuildID is to be autodetected.

Comment 3

[[e-mail] (:bhearsum)]

Forgot to mention that this version probably supersedes that in bug#393266

Comment 4

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 278430 [details]
PerfConfigurator with linux/mac support

you should write this against the latest version of PerfConfigurator.py checked in to tools/buildbot-configs/testing/talos last week. It includes some of the bugfixes you have here.

Comment 5

[[e-mail] (:bhearsum)]

Attachment: multiplatform configurator

Here ya go, in patch form. This version supports Talos 1. I've got a version that supports Talos 2 that I can throw up once that gets checked in.

Comment 6

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 278636 [details] [diff] [review]
multiplatform configurator

This looks good. At some point we'll want to rip out the _getBuildId() function in favor of something that doesn't rely on talkback but that's what we've got for now. We'll also have to update the version in the talos directory as well (or just move it there so we don't have to keep copying this around).

Comment 7

[[e-mail] (:bhearsum)]

Can we get this checked in?

Comment 8

[Rob Campbell [:rc] (:robcee)]

Checked into tools/buildbot-configs/testing/talos/perfmaster and testing/performance/talos

cvs commit: Examining .
Checking in PerfConfigurator.py;
/cvsroot/mozilla/tools/buildbot-configs/testing/talos/perfmaster/PerfConfigurator.py,v  <--  PerfConfigurator.py
new revision: 1.3; previous revision: 1.2
done

cvsci "bug 393252 - make PerfConfigurator.py support linux and mac, patch by [e-mail], r=robcee"
cvs commit: Examining .
cvs commit: Examining base_profile
cvs commit: Examining base_profile/Cache
cvs commit: Examining base_profile/bookmarkbackups
cvs commit: Examining page_load_test
cvs commit: Examining startup_test
Checking in PerfConfigurator.py;
/cvsroot/mozilla/testing/performance/talos/PerfConfigurator.py,v  <--  PerfConfigurator.py
new revision: 1.2; previous revision: 1.1
done

Comment 9

[(not currently active) Ted Mielczarek]

Mass move of Core:Testing bugs to mozilla.org:Release Engineering:Talos. Filter on RelEngTalosMassMove to ignore.