393548 - "Restart Thunderbird" button is too small, text doesn't fit

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Martijn Wargers (dead)]

When I crash in Thunderbird, the breakpad reporter comes up nicely, but the "Restart Thunderbirtd" button is too small for that text.

Maybe you need to keep this in mind regarding bug 358079?
Other languages might have even longer words.

Comment 1

[(not currently active) Ted Mielczarek]

campd: can we make this auto-size properly?

Comment 4

[(not currently active) Ted Mielczarek]

Attachment: os x patch

One platform down.

Comment 5

[(not currently active) Ted Mielczarek]

Attachment: win32 patch

Realized as I was creating this patch that we'll probably need to resize the "View Report" button as well.

Comment 6

[(not currently active) Ted Mielczarek]

Attachment: win32 patch

Easy enough.  The OS X patch doesn't need this bit, because it uses a label there, not a button.

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 287584 [details] [diff] [review]
os x patch

This isn't actually a problem on Linux.  Dave, can you take a look at these two patches?

Comment 8

[(not currently active) Ted Mielczarek]

Not really All/All, but 2/3 is close enough.

Comment 9

[(not currently active) Ted Mielczarek]

Comment on attachment 287584 [details] [diff] [review]
os x patch

Minor UI fix.  Actually seeking approval for both patches, but I'm too lazy to concatenate them.

Comment 10

[(not currently active) Ted Mielczarek]

Checked in.

Comment 11

[Marek Stępień [:marcoos, inactive]]

This still doesn't really work, which is a major problem for Breakpad localizability.

http://bugs.aviary.pl/attachment.cgi?id=935

(the button should read "Uruchom ponownie program Firefox", but you can only see just a part of it; the same thing happens with the "Wyślij zgłoszenie"/"Send report" button)

The screenshot comes from Windows, but on Mac it's even worse...

Comment 12

[(not currently active) Ted Mielczarek]

Marek:  This worked in my testing, but I was using English strings:
http://people.mozilla.com/~tmielczarek/crashreporter-long-strings.png

Is that Polish localization checked into CVS?  It may be a problem with the way we determine the length of non-ASCII strings.

Comment 13

[Marek Stępień [:marcoos, inactive]]

Yes, pl is in CVS. http://lxr.mozilla.org/l10n/source/pl/toolkit/crashreporter/crashreporter.ini

Comment 14

[(not currently active) Ted Mielczarek]

This WFM:
http://people.mozilla.com/~tmielczarek/crashreporter-pl.png
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2007121705 Minefield/3.0b3pre

Are you using an older version?  This may have landed after beta 1, I forget exactly when I checked it in.  I tried it in Vista as well and it works just the same.

Comment 15

[Marek Stępień [:marcoos, inactive]]

I'm not sure what version the reporter of that bug (http://bugs.aviary.pl/show_bug.cgi?id=1391) was using. 

I've seen this broken on the Mac in b1 and in a release candidate of beta 2 on the Mac and a few builds in the interim.

I will try to reproduce this it later today with another trunk build.

Comment 16

[(not currently active) Ted Mielczarek]

Ok, this does look terrible on Mac.  I'm going to be doing some more rework in bug 404855, so I'll make sure that gets fixed right in the process.