393887 - Star icon shouldn't be set for items in RSS / Live Bookmarks.

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Justin Dolske [:Dolske]]

When viewing a site from a Live Bookmark folder, the URL bar shows that star icon as turned on (yellow). This isn't really useful, because such feeds are ephemeral, and it's not really saved for future access. It's also a bit confusing to have sites suddenly appear to become bookmarked.

Comment 1

[(not reading, please use [e-mail] instead)]

I am to reproduce this with:

http://planet.mozilla.org/atom.xml
http://home.kairo.at/blog/2007-08/weekly_status_report_w34_2007

but note, I could not reproduce with:

http://en-us.fxfeeds.mozilla.com/en-US/firefox/headlines.xml
http://news.bbc.co.uk/2/hi/americas/6965602.stm

Comment 2

[Justin Dolske [:Dolske]]

I originally caught this with http://api.flickr.com/services/feeds/photos_public.gne?tags=firefox&lang=en-us&format=atom

Comment 3

[Phil Ringnalda (:philor)]

(In reply to comment #1)
> but note, I could not reproduce with:

A feed url that redirects to another URL, containing links that redirect from what's in the feed to different final URLs.

Comment 4

[(not reading, please use [e-mail] instead)]

I was hoping to use something like the type column of moz_bookmarks, but that only tells me if the bookmark is a folder, separator, bookmark or dynamic container.  perhaps we need a new value, for a livemark item?

otherwise, we may have to check to see if the bookmark has a "livemark/bookmarkFeedURI" annotation to determine if it is a livemark item or not.

asaf / dietrich, thoughts?

note, this bug also shows up with bug #387718 (the location bar dropdown should show a star next to bookmarked results)

Comment 5

[(not reading, please use [e-mail] instead)]

as part of his recent patch for bug #385266, asaf has a fix for this for the star button in the url bar, but for url bar autocomplete results (bug #387718), for performance reasons, checking if the bookmark's parent has an annotation of "livemark/feedURI" may not be performant enough.

for now, re-assign this bug to mano and I'll work about the url bar autocomplete result issue in bug #385266

Comment 6

[Asaf Romano (gone)]

Fixed in bug 385266.

Comment 7

[(not reading, please use [e-mail] instead)]

this doesn't appear to be fixed.

steps to reproduce:

1)  add http://weblogs.mozillazine.org/asa/index.rdf as a livebookmark
2)  refresh the livemark
3)  visit http://weblogs.mozillazine.org/asa/archives/2007/08/getting_involve.html

it appears bookmarked.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007083005 Minefield/3.0a8pre

re-opening.

(fwiw, see the second patch in bug #387718)

Comment 8

[(not reading, please use [e-mail] instead)]

> fwiw, see the second patch in bug #387718

spun off to bug #394484

Comment 9

[(not reading, please use [e-mail] instead)]

ok, the problem is with getMostRecentBookmarkForURI(), testing a fix.

Comment 10

[(not reading, please use [e-mail] instead)]

Attachment: patch

when checking if we have the livemark annotation, check the bookmarks parent ("folder") and not the grandparent ("parent").

it might be a good idea to rename folder and parent to parent and grandparent.

Comment 11

[Dietrich Ayala (:dietrich)]

Comment on attachment 279164 [details] [diff] [review]
patch

r=dietrich. please do make that naming fix to make things clearer.

Comment 12

[(not reading, please use [e-mail] instead)]

Comment on attachment 279164 [details] [diff] [review]
patch

sending review over to dietrich

Comment 13

[(not reading, please use [e-mail] instead)]

Attachment: patch as checked in (using parent and grandparent)

carrying over dietrich review

Comment 14

[(not reading, please use [e-mail] instead)]

fixed.

Checking in browser/components/places/content/utils.js;
/cvsroot/mozilla/browser/components/places/content/utils.js,v  <--  utils.js
new revision: 1.61; previous revision: 1.60
done

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

http://litmus.mozilla.org/show_test.cgi?id=4677

in-litmus+ (might be in the wrong subcategory, but we can always move it later)

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007091204 Minefield/3.0a8pre

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007091204 Minefield/3.0a8pre

with the STR in comment 7.

Comment 17

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv