394023 - Insert of attributes not reflected in bound form controls

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[John L. Clark]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070725 Firefox/2.0.0.6
Build Identifier: 2007-08-09-03-mozilla1.8

In some cases, when you add an attribute to an element, other expressions (such as for form controls) that reference the attribute are not updated.

Reproducible: Always

Comment 1

[John L. Clark]

Attachment: Test form demonstrating the bug

When you activate the edit button next to an email address, the corresponding `person` element is marked for editing with an `s:selected` attribute; the edit group should refer to the "selected" `person` element, but it does not rebind to the newly selected `person` element.  (Note that I am using XForms Buddy to verify that the attributes are actually being placed on the correct `person` element.)  Also, note that the `xf:output` that counts the number of `s:selected` attributes is also not updated, and finally that the "Unselect all" button does not delete the `s:selected` attributes that are added using the edit button.

Comment 2

[Merle Sterling]

The namespace of an attribute was not considered when inserting an attribute so the actual name of the attribute that was inserted was 's:selected'. XPath however, recognizes s:selected as a namespace prefix + local name and did not match a node with an attribute whose local name was s:selected.

Comment 3

[Merle Sterling]

Attachment: patch

Take into account namespaces when checking for duplicate attributes and inserting a new attribute.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 278689 [details] [diff] [review]
patch

Not sure if XForms patches need approval while in
M8 freeze. XForms is not part of the build.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 278689 [details] [diff] [review]
patch

According to mozilla.dev.planning, this doesn't need approval

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Checked in

Comment 7

[aaronr]

checked into 1.8 branch via bug 410239.