394111 - [FIX]Another way to trigger "ASSERTION: expected the float to be a child of the outer CB" with float, block-in-inline

Status: RESOLVED FIXED

(Core :: Layout, defect, P1)

Description

[Jesse Ruderman]

Attachment: testcase

Same pair of assertion as in bug 393671, different testcase.

###!!! ASSERTION: expected the float to be a child of the outer CB: 'outOfFlowFrame->GetParent() == aOuterState.mFloatedItems.containingBlock', file /Users/jruderman/trunk/mozilla/layout/base/nsCSSFrameConstructor.cpp, line 1602

###!!! ASSERTION: float wasn't in the outer state float list: 'Not Reached', file /Users/jruderman/trunk/mozilla/layout/base/nsCSSFrameConstructor.cpp, line 1607

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

So the issue is that we insert the new frames into the trailing inline before calling MoveChildrenTo.  We never used to have a situation where MoveChildrenTo got a list of frames but wasn't supposed to move them all..  but that's exactly what we have now.  So pass in the place to stop as well.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Fixed.