394120 - "ASSERTION: post-reflow queues not empty" with xul:listboxbody and xul:text

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Jesse Ruderman]

Attachment: testcase (reload to see the assertions)

*Reloading* the testcase triggers:

###!!! ASSERTION: post-reflow queues not empty.  This means we're leaking: 'mFirstCallbackEventRequest == nsnull && mLastCallbackEventRequest == nsnull', file /Users/jruderman/trunk/mozilla/layout/base/nsPresShell.cpp, line 1402

###!!! ASSERTION: Some objects allocated with AllocateFrame were not freed: 'mFrameCount == 0', file /Users/jruderman/trunk/mozilla/layout/base/nsPresShell.cpp, line 673

I'm marking this bug as major because being able to test for the "Some objects allocated with AllocateFrame were not freed" assertion is important for detecting a class of memory safety bugs.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: proposed patch

Sorry, my mistake.
Better to post the callback when reflowing, then it gets called always and there
is no need to cancel it.

Comment 2

[Daniel Veditz [:dveditz]]

qawanted: verify this doesn't regress on the 1.8 branch after bug 387033 lands

Comment 3

[Martijn Wargers (dead)]

I can't really verify this on the 1.8 branch.
My debug 1.8 branch builds are from before this patch was checked in, but I don't get any assertion when reloading the testcase with those.

Comment 4

[Jesse Ruderman]

Crashtest checked in.