394226 - can't drag favicon to an empty bookmarks toolbar

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Dave Camp (:dcamp)]

When I have an empty bookmarks toolbar, dragging from the favicon doesn't create a bookmark there.  The purple caret shows up but when I drop, nothing is created and the caret doesn't go away.

Dragging from the bookmarks organizer works ok, and once there's another bookmark in the toolbar, dragging the favicon works too.

Comment 1

[(not reading, please use [e-mail] instead)]

we're throwing an exception in TBV_DO_onDragOver(), in toolbar.xml

TypeError: this._self.lastChild has no properties

working on it.

Dave, thanks for the bug report!

Comment 2

[(not reading, please use [e-mail] instead)]

fix in hand

Comment 3

[(not reading, please use [e-mail] instead)]

Attachment: fix

Comment 4

[(not reading, please use [e-mail] instead)]

Comment on attachment 278913 [details] [diff] [review]
fix

would (of course), take a review from dietrich as well.

Comment 5

[Dietrich Ayala (:dietrich)]

Comment on attachment 278913 [details] [diff] [review]
fix

looks good, thanks for clearing up over irc.

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 278913 [details] [diff] [review]
fix

seeking approval for m8

Comment 7

[(not reading, please use [e-mail] instead)]

Attachment: updated patch, per mconnor's comment over irc

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 280126 [details] [diff] [review]
updated patch, per mconnor's comment over irc

let's get this in tonight. thanks!

Comment 9

[(not reading, please use [e-mail] instead)]

fixed.

Checking in browser/components/places/content/toolbar.xml;
/cvsroot/mozilla/browser/components/places/content/toolbar.xml,v  <--  toolbar.x
ml
new revision: 1.102; previous revision: 1.101
done

thanks again to dcamp for the bug report.

Comment 10

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007091322 Minefield/3.0a8pre ID:2007091322

VERIFIED

Comment 11

[Tracy Walker [:tracy]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007091304 Minefield/3.0a8pre

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

https://litmus.mozilla.org/show_test.cgi?id=5026

in-litmus+

Comment 13

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv