394285 - Add Bookmark popup should say Add Bookmark instead of Done

Status: RESOLVED DUPLICATE of bug 393509

(Firefox :: Bookmarks & History, defect)

Description

[Ria Klaassen (not reading all bugmail)]

Steps to reproduce:

- Go to a site and call the Add Bookmark popup
- Note that you have the choice between Delete and Done. Both options seem to say that I already bookmarked this site, even if I did not

I'd say, Add Bookmark is the clearest button text in this case but I also wonder why Delete is not grayed out if the site is not yet already bookmarked.

Comment 1

[Jeremy Baron]

I would bet that it has in fact already been bookmarked.  Note the star changes color.

Comment 2

[Ria Klaassen (not reading all bugmail)]

OK, a search showed me that the bookmark is indeed somewhere, although I don't know where. I think it has a hidden or non-existing default folder. Also a browser restart doesn't reveal where it is. It must be a mess in my bookmarks in the meantime with all the sites I bookmarked unintentionally. :)
I'm afraid this is an invalid bug :(, caused by misunderstanding of the feature + the hidden folder.
 

Comment 3

[Alfred Kayser]

Note, this is a 'valid' bug.

When a user (like the reporter) clicks on 'Bookmark this Link', the panel that is shown doesn't describe that the bookmark has been created (by that click).
The 'delete' logic is then strange. Normal behaviour is to provide a 'Cancel'  button to 'undo' or 'cancel' that bookmark operation of that click.

Using Delete/Done instead of the usual 'Cancel/Ok' to abort or confirm the 'Bookmark This Link' operation is new and strange to many people. Because the panel doesn't describe this people will be confused by this.

Comment 4

[Al Billings [:abillings - ex-MoCo]]

Ria, the added bookmark when you click in the star does go someplace but you won't see it in any of your views unless you search for it.

I opened a bug the other day on this, bug 393944.

Comment 5

[u88484]

Attachment: Patch

Changes:
"Done" to "Add Bookmark"
"Delete" to "Cancel"

Also swaps the buttons location (bug 392976), even though that was another bug I figured since messing with same code might as well do it in this patch also.

Comment 6

[Asaf Romano (gone)]

Comment on attachment 281004 [details] [diff] [review]
Patch

As mentioned above, the item is bookmarked before the panel is opened (you can see the instant-apply interaction in action by choosing Bookmarks Toolbar Folder as the container for the "new" bookmark).

Comment 7

[u88484]

So should it be "Ok" then?

Comment 8

[Ria Klaassen (not reading all bugmail)]

Maybe there should be a message on the pop-up like:

You just added a bookmark to your bookmarks collection.
 
-----   ---------------------
OK   | |  Delete new bookmark |
-----   ---------------------

Comment 9

[Alex Faaborg [:faaborg] (Firefox UX)]

These issues have already been debated in other bugs and on dev.apps.firefox.  I would have commented here earlier but I didn't know about this bug.

Here are the planned change for i8 of the new bookmark dialog UI (bug #393509):

Panel is instant apply:
-Add "Page Bookmarked" at the top of the panel
-remove done/ok/cancel, add small close button in the top left corner (right on
mac)
-There is still a remove bookmark button
-Clicking anywhere outside of the panel dismisses it

Comment 10

[Alex Faaborg [:faaborg] (Firefox UX)]

sorry, switch right/left for windows/mac

Comment 11

[u88484]

Alex, so can we just mark this a dupe of bug 393509 since it seems that the dialog is going to be redone in that bug anyways?

Comment 12

[Ria Klaassen (not reading all bugmail)]

Yeah this could be marked as a duplicate if it also reveals where the All Bookmarks folder is so I can delete all those unintended bookmarks :). In fact it was just a misunderstanding, so INVALID is also fine with me. 

Comment 13

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv