394292 - http://www.mozilla.org/download redirects not working correctly

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Jason Orendorff [:jorendorff]]

http://www.mozilla.org/download redirects to a page where you can download Mozilla Suite.  "Best of 2003", raves PCWORLD!

It shouldn't redirect at all.  If I understand Apache correctly, the default would be to display http://www.mozilla.org/download.html which I think is the right thing.

Comment 1

[Wolf [:wolf]]

Apache Default would be to look for a /download/ directory or file, then only if negotiation is enabled, find download.html.

It appears there's a redirection for /download/ to /products/mozilla1.x/ in place, probably from along time ago, when the product pages were created originally.

It should probably be redirected to download.html or changed to a 410 Gone.

Comment 2

[Robert Kaiser]

AFAIK, negotiation should be enabled, so removing the redirect should make it go to download.html

Comment 3

[Reed Loden [:reed]]

Removing download/.htaccess;
/www/mozilla-org/html/download/.htaccess,v  <--  .htaccess
new revision: delete; previous revision: 1.1
done

Maybe this will work? We'll have to wait another day for the nightly clobber to remove it, but we'll see...

Comment 4

[Jason Orendorff [:jorendorff]]

No such luck.  Can anyone figure out why it's still redirecting?

Is the .htaccess file still there on the server somehow?

Comment 5

[David Boswell]

It looks like this URL is now being redirected to a non-existant page at:

http://www.mozilla.org/projects/browsers.htmldownload

This should be pointing to the download.html page (or to wherever that page gets redirected if the downloads page is removed).

Comment 6

[Robert Kaiser]

I think we should redirect to projects and make download.html redirect there at the same time. The projects page points to all apps that were available from the download page(s) and mozilla.org is no download site (any more).

Comment 7

[David Boswell]

A while ago I tried to redirect www.mozilla.org/download to the projects page but it didn't work.  From .htaccess:

RewriteRule ^download(?:/(?:index.html)?)?$ http://www.mozilla.org/projects/ [R]

As mentioned earlier in this bug, something else seems to be going on here.

Comment 8

[Robert Kaiser]

Why go through mod_rewrite at all and not just use
RedirectMatch permanent ^/download http://www.mozilla.org/projects/
instead?

I think we should reorder the top-level .htaccess some time and sort it by the URL of the redirected pages - the huge list we have right now is hard to navigate.

Comment 9

[David Boswell]

Reed, can you see if there is a redirect on the server that is conflicting with the redirect in the .htaccess file?

Re comment #8, I think that suggestion is fine once we get the redirects working correctly from .htaccess.

Comment 10

[Reed Loden [:reed]]

(In reply to comment #9)
> Reed, can you see if there is a redirect on the server that is conflicting with
> the redirect in the .htaccess file?

Yep, there is. I'll be moving all the server-side redirects into .htaccess soon, so everything will be able to be managed from the .htaccess file.

Comment 11

[Reed Loden [:reed]]

I did this a long time ago...

Comment 12

[Robert Kaiser]

But it redirects to download.html, while all both download/ and download.html should redirect5 to projects/ :-/

Comment 13

[David Boswell]

Attachment: Patch to fix download redirect issues

Attached is a patch that attempts to fix the problems we've had with the downloads redirects.  It removes one of the duplicate redirects for /downloads and add a redirect for download.html.  Kairo, if this looks good to you I can check it in.

Comment 14

[Reed Loden [:reed]]

Comment on attachment 359345 [details] [diff] [review]
Patch to fix download redirect issues

>+Redirect permanent /download.html http://www.mozilla.org/projects/
...
> RewriteRule ^download(?:/(?:index.html)?)?$ http://www.mozilla.org/projects/ [R]


Seems like you could combine these...

Comment 15

[David Boswell]

If I knew anything about regular expressions I probably could combine them :)

Comment 16

[Robert Kaiser]

Comment on attachment 359345 [details] [diff] [review]
Patch to fix download redirect issues

This basically should work, but why not simply go with what I proposed in comment #8 for both lines mentioned by reed there?

Comment 17

[David Boswell]

Kairo, your suggestion in comment #8 is fine with me, I just overlooked it when I posted that last patch.  Do you want to go ahead and check in your change?  I'll probably be unable to get to it myself until later this week.

Comment 18

[Robert Kaiser]

I just checked in that change, here's an inline diff just for documenting the actual changes:

Index: .htaccess
===================================================================
RCS file: /www/mozilla-org/html/.htaccess,v
retrieving revision 1.153
retrieving revision 1.155
diff -u -3 -p -r1.153 -r1.155
--- .htaccess   25 Dec 2008 04:02:33 -0000      1.153
+++ .htaccess   3 Feb 2009 16:45:15 -0000       1.155
@@ -20,6 +20,7 @@ Redirect permanent /docs/netlib/new-hand
 Redirect permanent /docs/plugin.html http://www.mozilla.org/projects/plugins/
 Redirect permanent /docs/refList/refNSPR/ http://www.mozilla.org/projects/nspr/reference/html/
 Redirect permanent /download-mozilla.html http://developer.mozilla.org/en/docs/Download_Mozilla_Source_Code
+RedirectMatch permanent ^/download http://www.mozilla.org/projects/
 Redirect permanent /glimpsesearch.html http://lxr.mozilla.org/
 Redirect permanent /index2.html http://www.mozilla.org/
 Redirect permanent /my-mozilla.html http://www.mozilla.org/
@@ -757,7 +758,6 @@ RewriteRule ^build(?:/(?:index.html)?)?$
 RewriteRule ^docs/dom(?:/(?:index.html)?)?$ http://developer.mozilla.org/en/docs/About_the_Document_Object_Model [R]
 RewriteRule ^docs/dom/domref(?:/(?:index.html)?)?$ http://developer.mozilla.org/en/docs/Gecko_DOM_Reference [R]
 RewriteRule ^quality/help(?:/(?:index.html)?)?$ http://quality.mozilla.org/get-involved [R]
-RewriteRule ^download(?:/(?:index.html)?)?$ http://www.mozilla.org/projects/ [R]
 RewriteRule ^donate(?:/(?:index.html)?)?$ http://www.mozilla.org/foundation/donate.html [R]
 RewriteRule ^bugs(?:/(?:index.html)?)?$ http://developer.mozilla.org/en/Bug_writing_guidelines [R]
 RewriteRule ^status(?:/(?:index.html)?)?$ https://wiki.mozilla.org/WeeklyUpdates [R]
@@ -791,7 +791,6 @@ Redirect permanent /webtools http://cvs-

 # Redirects to other pages on this site.
 Redirect permanent /mozilla1.x http://www.mozilla.org/products/mozilla1.x
-Redirect permanent /download http://www.mozilla.org/products/mozilla1.x/download
 Redirect permanent /camino http://www.mozilla.org/products/camino
 Redirect permanent /firebird http://www.mozilla.org/products/firebird
 Redirect permanent /firefox http://www.mozilla.org/products/firefox


Marking FIXED, but we should probably check that it works correctly once the site has updated.

Comment 19

[Robert Kaiser]

Better formatted visualization of the checkin(s): http://bonsai-www.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=.htaccess&branch=&root=/www&subdir=mozilla-org/html&command=DIFF_FRAMESET&rev1=1.153&rev2=1.155

Comment 20

[David Boswell]

http://www.mozilla.org/download is bringing up a 404 for me, although other variations of the download URL are working like www.mozilla.org/download.html.

Comment 21

[Robert Kaiser]

It looks like everything that would have gone to the download/ directory is going 404, all other variations redirect. Somewhat strange. Is there still a download/ directory on the server that might even have a .htaccess by itself or so?

Comment 22

[fantasai]

That's not the problem. /downloadfu redirects to /projects no problem. But /download/ doesn't. The regex seems to be a bit weird that way. I've added (/.*)? to the end of it, maybe that will help.

Comment 23

[Robert Kaiser]

fantasai:
The strange thing is that /downloadfoo/foo.html redirects and /download/foo.html doesn't, which sounds somewhat strange if the possible existence of a /download/ directory doesn't make that difference.

Comment 24

[fantasai]

I've CVS-removed download.js and download.html, added in a .htaccess rule that worked fine when I used a substring other than 'download'... There used to be a download directory in CVS. It's empty right now. I don't know if the server still has a copy or what. See http://bonsai-www.mozilla.org/rview.cgi?dir=mozilla-org/html&cvsroot=/www&module=default

Comment 25

[David Boswell]

Instead of a 404 page, I'm now seeing what looks like a script at

http://www.mozilla.org/download

Comment 26

[Robert Kaiser]

That's download.js, if I'm not mistaken.

Comment 27

[David Boswell]

I think we should raise the priority of getting this fixed.  The downloads link gets a lot of traffic and it should go to some page while we're getting the redirects sorted out.

Another question: how many other files can we remove along with the download.html page?  I believe someone mentioned that the VARIABLES file could be removed, but not sure if it's used for other things (like the home page download links?)

Comment 28

[Samuel Sidler (old account; do not CC)]

VARIABLES (the version number part of it at least) is used for version numbers on the home page. I update it every time we have a Camino release.

Comment 29

[Robert Kaiser]

I tried to also add a RewriteRule now, but it didn't help either. Interestingly, the archive site seems to redirect to the live site's project list though...

Comment 30

[fantasai]

I removed download.js from CVS yesterday. :/ It shouldn't be turning up at all.
Can we purge the server's copy of the website or something?

Comment 31

[Reed Loden [:reed]]

(In reply to comment #30)
> I removed download.js from CVS yesterday. :/ It shouldn't be turning up at all.
> Can we purge the server's copy of the website or something?

That's done every 24 hours.

Comment 32

[Reed Loden [:reed]]

(In reply to comment #30)
> I removed download.js from CVS yesterday. :/

Removing download.js caused bug 476990. *sigh*

Comment 33

[David Boswell]

www.mozilla.org/download is redirecting correctly now.  Can someone else check the various download URLs and verify that things look good to them too?

Comment 34

[Robert Kaiser]

The redirect doesn't work for me, maybe some webheads have it working and some not?

Comment 35

[Robert Kaiser]

OK, things seem to work fine now for me - finally. Yesterday I still got download.js here at FOSDEM, but now it redirects fine. yay!