Closed Bug 394352 Opened 17 years ago Closed 17 years ago

protect navigator.offlineResources with a permission

Categories

(Core :: DOM: Core & HTML, defect, P2)

defect

Tracking

()

RESOLVED DUPLICATE of bug 402272

People

(Reporter: dcamp, Assigned: dcamp)

References

Details

Attachments

(2 files)

Since navigator.offlineResources lets sites pin data on the user's disk, it should probably be protected by a permission.

The attached patch throws a security exception when the API is accessed without the necessary permissions.
Flags: blocking1.9?
Attachment #278997 - Flags: superreview?(jst)
Attachment #278997 - Flags: review?(jst)
Depends on: 394392
Assignee: nobody → dcamp
Flags: blocking1.9? → blocking1.9+
Attachment #278997 - Flags: superreview?(jst)
Attachment #278997 - Flags: superreview+
Attachment #278997 - Flags: review?(jst)
Attachment #278997 - Flags: review+
Attachment #278997 - Flags: approval1.9+
Blocks: 398161
Blocks: 397416
Attached patch test fixSplinter Review
this fix is needed to fix the tests after adding the permission.
Attachment #284687 - Flags: review?(jst)
Attachment #284687 - Flags: review?(jst) → review+
Comment on attachment 278997 [details] [diff] [review]
protect offline apps with a permission

Clearing the approval flag.  This is going to get caught up in the upcoming API changes, and this doesn't make sense to commit without UI to manage the permission anyway.
Attachment #278997 - Flags: approval1.9+
Dcamp, what's going on here? Shouldn't we land this to let the UI folks build on it? What priority do you think this should have?
Priority: -- → P2
This patch has ended up as part of the patch for bug 402272, so we can probably close this bug...
Sold!
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → DUPLICATE
Component: DOM: Mozilla Extensions → DOM
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: