394741 - Searching in history sidebar doesn't work / returns nothing.

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a8pre) Gecko/2007090205 Minefield/3.0a8pre ID:2007090205

1. New profile, start firefox
2. Visit a load of sites
3. Open history sidebar (CTRL+H)
4. Search for something that's in your history

Expected:
- Results returned

Actual:
- Nothing ever returned

Nothing is thrown to the error console (that I can see, anyway)

Comment 1

[Steve England [:stevee]]

Works: 20070901_1244_firefox-3.0a8pre.en-US.win32
Broken: 20070901_1429_firefox-3.0a8pre.en-US.win32

Checkins to module PhoenixTinderbox between 2007-09-01 12:44 and 2007-09-01 14:28 : 
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1188675840&maxdate=1188682139

Due to bug 317847

Comment 2

[Dietrich Ayala (:dietrich)]

Attachment: fix v1

the included test fails without this fix.

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 279484 [details] [diff] [review]
fix v1

r=sspitzer, thanks for the adding a test as well.

Comment 4

[Dietrich Ayala (:dietrich)]

Checking in toolkit/components/places/src/nsNavHistory.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.cpp,v  <--  nsNavHistory.cpp
new revision: 1.165; previous revision: 1.164
done
Checking in toolkit/components/places/tests/unit/test_history.js;
/cvsroot/mozilla/toolkit/components/places/tests/unit/test_history.js,v  <--  test_history.js
new revision: 1.7; previous revision: 1.6
done

Comment 5

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a8pre) Gecko/2007090614 Minefield/3.0a8pre ID:2007090614
VERIFIED

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv