Closed
Bug 395249
Opened 17 years ago
Closed 17 years ago
switch nsSessionStartup to XPCOMUtils
Categories
(Firefox :: Session Restore, defect)
Firefox
Session Restore
Tracking
()
RESOLVED
FIXED
People
(Reporter: sayrer, Assigned: sayrer)
Details
Attachments
(1 file)
|
9.93 KB,
patch
|
dietrich
:
review+
mconnor
:
approval1.9+
|
Details | Diff | Splinter Review |
It will be smaller this way.
|
Assignee | |
Comment 1•17 years ago
|
||
Attachment #279946 -
Flags: review?(dietrich)
|
||
Updated•17 years ago
|
OS: SunOS → All
Hardware: PC → All
|
|
||
Comment 2•17 years ago
|
||
Comment on attachment 279946 [details] [diff] [review] use XPCOMUtils thanks, r=me
Attachment #279946 -
Flags: review?(dietrich) → review+
|
||
Comment 3•17 years ago
|
||
Comment on attachment 279946 [details] [diff] [review] use XPCOMUtils Nit: > + // make BrowserGlue a startup observer Copy&paste oversight: this is SessionStartup, not BrowserGlue. Otherwise this looks like some nice savings. r+ with nit fixed. Mind to do nsSessionStore.js as well?
|
|
Assignee | |
Updated•17 years ago
|
Attachment #279946 -
Flags: approval1.9?
|
|
Assignee | |
Comment 4•17 years ago
|
||
(In reply to comment #3) > (From update of attachment 279946 [details] [diff] [review]) > Nit: > > + // make BrowserGlue a startup observer Whoops, I'll fix that comment before checking in. Ryan Flint is converting nsSessionStore.js
|
||
Updated•17 years ago
|
Attachment #279946 -
Flags: approval1.9? → approval1.9+
|
||
Updated•17 years ago
|
Assignee: nobody → sayrer
Version: unspecified → Trunk
|
|
Assignee | |
Updated•17 years ago
|
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•