39532 - Turn on caching of widget changes

Status: RESOLVED DUPLICATE of bug 238493

(Core :: Web Painting, defect, P4)

Description

[Kevin McCluskey (gone)]

There are a number of bugs which are the result of nsIWidget's instances being 
positioned multiple times during reflow. [e-mail] built a mechanism 
which caches the widget changes and applies the changes when caching is turned 
off. He found a number of problems when he turned it on initially. These 
problems need to be resolved before it can be turned on permanently.

I was able to fix a number of bugs by adding the following code to 
nsTableOuterFrame.cpp and enabling widget caching in nsViewManager2.

 nsCOMPtr<nsIViewManager> vm;
  nsCOMPtr<nsIPresShell> shell;
  aPresContext->GetShell(getter_AddRefs(shell));

  if (shell) {
    shell->GetViewManager(getter_AddRefs(vm));
    if (nsnull != vm) {
      vm->CacheWidgetChanges(PR_TRUE);
    }
  }

  ...

  if (nsnull != vm) {
    vm->CacheWidgetChanges(PR_FALSE);
  }

After discussing it with Eric, we decided to wait for the general solution 
instead of checking this local widget caching since anything within the table 
may exhibit the problems he saw when he turned on the global widget change 
caching.

Comment 1

[Eric Vaughan]

This has to do with that widget caching I was talking about.

Comment 2

[Peter Trudelle]

back to evaughan

Comment 3

[John Morrison]

mass-moving all evaughan non-nsbeta3+ bugs to 'Future' milestone 
(per trudelle). 

Comment 4

[Kevin McCluskey (gone)]

Taking this bug

Comment 5

[Kevin McCluskey (gone)]

Build moving all existing future-P3 bugs to future-P4.

Comment 6

[Martijn Wargers (dead)]

Well, this just seems like a duplicate of bug 238493 to me, so marking it as duplicate. This is fixed anyway.

*** This bug has been marked as a duplicate of 238493 ***