395426 - Contextmenu opened using keyboard should have .button == 0

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: testcase

This is a regression from Bug 354694.
Because 1.8 reports .button == 0, I think we should keep that functionality.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: proposed patch

Neil, could you test this on Windows.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Automated tests
http://www.mozilla.pettay.fi/moztests/context_for_local_testing.xhtml
though, that is just testing windowutils.

Comment 3

[Neil Deakin]

Comment on attachment 280100 [details] [diff] [review]
proposed patch

>-      button = eRightButton;
>+      button = (context == eNormal) ? eRightButton : eLeftButton;
>     }
>   }
> #ifdef NS_DEBUG
>   ~nsMouseEvent() {
>-    NS_WARN_IF_FALSE(message != NS_CONTEXTMENU || button == eRightButton,
>+    NS_WARN_IF_FALSE(message != NS_CONTEXTMENU ||
>+                     button ==
>+                       ((context == eNormal) ? eRightButton : eLeftButton),

I think these checks would be easier to understand if there were written as:

(context == eContextMenuKey) ? eLeftButton : eRightButton