Closed
Bug 395526
Opened 17 years ago
Closed 17 years ago
Change assertions to real errors in mozStorageStatement.cpp
Categories
(Toolkit :: Storage, defect)
Toolkit
Storage
Tracking
()
RESOLVED
FIXED
mozilla1.9beta1
People
(Reporter: sdwilsh, Assigned: sdwilsh)
Details
Attachments
(1 file, 1 obsolete file)
|
13.08 KB,
patch
|
bzbarsky
:
approval1.9+
|
Details | Diff | Splinter Review |
We need to actually error out and not just assert here...
|
Assignee | |
Comment 1•17 years ago
|
||
This makes me happier :)
Attachment #281511 -
Flags: review?(sspitzer)
|
||
Comment 2•17 years ago
|
||
Comment on attachment 281511 [details] [diff] [review] v1.0 r=sspitzer, but EscapeStringForLIKE() doesn't need mDBConnection or mDBStatement to be called, so perhaps remove that change
Attachment #281511 -
Flags: review?(sspitzer) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Good point, updated accordingly.
Attachment #281511 -
Attachment is obsolete: true
Attachment #281591 -
Flags: approval1.9?
|
|
Assignee | |
Updated•17 years ago
|
Target Milestone: --- → mozilla1.9 M9
|
||
Comment 4•17 years ago
|
||
Comment on attachment 281591 [details] [diff] [review] v1.1 a=bzbarsky
Attachment #281591 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 5•17 years ago
|
||
Checking in storage/src/mozStorageStatement.cpp; new revision: 1.28; previous revision: 1.27
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•