Closed
Bug 396044
Opened 17 years ago
Closed 17 years ago
Warning: usage of uninitialized variable in ckfw/object.c(174)
Categories
(NSS :: Libraries, defect)
NSS
Libraries
Tracking
(Not tracked)
RESOLVED
FIXED
3.12
People
(Reporter: bugzilla, Assigned: bugzilla)
References
()
Details
Attachments
(1 file)
918 bytes,
patch
|
rrelyea
:
review+
|
Details | Diff | Splinter Review |
VC8 reports a warning C4700, cause *fwObject isn't initialized before it's returned (see URL).
Assignee | ||
Comment 1•17 years ago
|
||
The patch changes the return value to (NSSCKFWObject *)NULL (like it's done in similar cases before and after the changed line in that file).
Comment 2•17 years ago
|
||
Comment on attachment 290980 [details] [diff] [review] return NULL instead of uninitialized fwObject Let's ask the author for review
Attachment #290980 -
Flags: review?(nelson) → review?(rrelyea)
Comment 3•17 years ago
|
||
Comment on attachment 290980 [details] [diff] [review] return NULL instead of uninitialized fwObject r+ rrelyea or alternately fwObject could be initialized to NULL, but this patch follows the existing style better. bob
Attachment #290980 -
Flags: review?(rrelyea) → review+
Assignee | ||
Updated•17 years ago
|
Keywords: checkin-needed
Comment 4•17 years ago
|
||
NSS is restricted, so somebody from NSS will need to commit this for you.
Comment 5•17 years ago
|
||
wtc, mind landing this for Aqualon? I don't have access to NSS.
Comment 6•17 years ago
|
||
I checked in the patch on the NSS trunk for NSS 3.12. Checking in object.c; /cvsroot/mozilla/security/nss/lib/ckfw/object.c,v <-- object.c new revision: 1.15; previous revision: 1.14 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → 3.12
You need to log in
before you can comment on or make changes to this bug.
Description
•