396130 - [Mozilla 24] Embed "Firefox Lightning" script in mozilla.com

Status: RESOLVED WONTFIX

(www.mozilla.org :: General, defect)

Description

[u217243]

Attachment: patch

This is a special program around Mozilla 24 - Spread fire around the world!

http://tomoshibi.mozilla24.com/fire/

Please embed this script in mozilla.com site:

<script type="text/javascript" src="http://tomoshibi.mozilla24.com/fire/api/firescript.jsp"></script>

We think our server will be OK.

Comment 1

[Paul Kim]

review by webdev?

if clouserw or morgamic signs off, a=pkim

Comment 2

[Reed Loden [:reed]]

It's not actually loading any JavaScript at all (just 13 blank lines), so I'm guessing they are just (ab)using <script> as a way to call the script, which just updates some database with the IP that called it so they can do geo-ip mapping to display the user on the map. Seems fine to me.

Comment 3

[Michael Morgan [:morgamic]]

r=morgamic

Comment 4

[Reed Loden [:reed]]

Sending        trunk/includes/header-portal-pages.inc.php
Sending        trunk/includes/header.inc.php
Transmitting file data ..
Committed revision 6811.

Sending        production/includes/header-portal-pages.inc.php
Sending        production/includes/header.inc.php
Transmitting file data ..
Committed revision 6812.

Comment 5

[u217243]

The script has fired our Lightning Map server. We are tuning up the configuration but need some extinguishers. Can you put the script only on your home page?

Comment 6

[u217243]

Attachment: diff 2

firescript: removed from the include files, added to the home page.

Comment 7

[Justin Fitzhugh]

a) bad idea to have mozilla.com rely on an external site
b) the mozilla japan server can't handle the load

We are reverting this change asap.

Comment 8

[Reed Loden [:reed]]

Seems like this would be better as a fake 1x1 image so that it doesn't rely on <script>. ...or even, put the script at the bottom of the page so the rest of the page loads first.

Comment 9

[Michael Morgan [:morgamic]]

No, we shouldn't be relying on another site.

Comment 10

[Michael Morgan [:morgamic]]

So...

Talked to Kohei and what I told him was there are a couple of possibilities:
- backfill the IPs for the mozilla24 map from logs (entirely background)
- use an asynchronous request called via setTimeout() (not ieal)

But there are privacy questions surrounding logging IPs on a diff site that we haven't even touched on.  And there is still the load issue which remains untested.

In the future, I'd suggest not pushing something live in the middle of the night -- and I'd like to be cc'd on the actual IT bug?

Comment 11

[Justin Fitzhugh]

We will not deploy this again. period.  this was a bad idea on many levels.