396200 - XP build system fixes: arbitrary zlib and windows-debug warnings

Status: VERIFIED FIXED

(Tamarin Graveyard :: Build Config, defect)

Description

[Benjamin Smedberg]

Attachment: zlib and windows linkage fixes, rev. 1

This patches fixes two independent issues:

1) Allow the build system to include and link against an arbitrary zlib. This will help the Mozilla build to use our in-tree zlib: it will also help builders on windows who download a zlib off the interweb, because there isn't a builtin zlib on Windows.

2) Fixes Windows linkage rules so that you can link against the static CRT or the dynamic CRT, and so that avmshell.exe has the proper suffix. It also disables compiler warning C4291: http://msdn2.microsoft.com/en-us/library/cxdxz3x6(VS.80).aspx This warning only appears in debug builds which have exceptions enabled.

Comment 1

[Benjamin Smedberg]

Attachment: Allow building MMgc as a sharedlib, rev. 2

This patch subsumes the first: in addition to the zlib/windows fixes, it fixes a windows dependency-generation error and allows one to optionally build MMGC as a shared library.

I have this as a stack of patches, so I can provide them separate if that would be easier to review.

Comment 2

[Tommy Reilly]

Comment on attachment 281849 [details] [diff] [review]
Allow building MMgc as a sharedlib, rev. 2

Looks fine, wish the public API set was smaller, stupid C++ !

Comment 3

[Benjamin Smedberg]

Pushed to tamarin-central, changeset 167/08322d1de212