396424 - Calculate selected state for currently active ARIA tab

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

An ARIA tab should have STATE_SELECTED if the current focus (gLastFocusedNode) is inside the tab container it is a label for.

Comment 1

[alexander :surkov (:asurkov)]

Attachment: like this?

Comment 2

[alexander :surkov (:asurkov)]

testcase http://test.cita.uiuc.edu/aria/tabpanel/tabpanel1.php, but not sure how to test it due to focus is changed.

Comment 3

[Aaron Leventhal]

Comment on attachment 281799 [details] [diff] [review]
like this?

The code looks good but we need to test it. What do you mean focus has changed?

Can you fix the Mozilla testcase so it uses labelledby?
http://www.mozilla.org/access/dhtml/tabpanel

Comment 4

[Aaron Leventhal]

Comment on attachment 281799 [details] [diff] [review]
like this?

Clearing review until we get test results.

Comment 5

[alexander :surkov (:asurkov)]

Attachment: testcase

yes, it works. Though should we set 'selected' if tab has focused state?

Comment 6

[alexander :surkov (:asurkov)]

(In reply to comment #3)

> Can you fix the Mozilla testcase so it uses labelledby?
> http://www.mozilla.org/access/dhtml/tabpanel
> 

How can I do it? Should I have special rights?

Comment 7

[Aaron Leventhal]

Surkov, you can just to use your regular CVS account.

See http://www.mozilla.org/contribute/writing/cvs
You can check out the mozilla.org content tree with 
cvs co MozillaOrgTrim

To get the mozilla.org/access tree I think you'll need to
cd docs/mozilla-org/html

cvs up -d access

Comment 8

[Aaron Leventhal]

> yes, it works. Though should we set 'selected' if tab has focused state?
Yes, we should for consistency.

Comment 9

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 10

[alexander :surkov (:asurkov)]

(In reply to comment #7)
> Surkov, you can just to use your regular CVS account.

it looks I haven't permissions.

Comment 11

[Aaron Leventhal]

Surkov, when you check this in please also include information about this on the wiki:

You can put it under the section on the tab role.
http://developer.mozilla.org/en/docs/ARIA_to_API_mapping

"wairole:tab" -> ROLE_PAGETAB
    * Accessible name okay from children 
    * Selected state calculated by user agent, using the following algorithm: [explain]

Comment 12

[Aaron Leventhal]

Also, please file a bug on mozilla.org site content to give you CVS write permissions there and CC me.

Comment 13

[alexander :surkov (:asurkov)]

(In reply to comment #12)
> Also, please file a bug on mozilla.org site content to give you CVS write
> permissions there and CC me.
> 

I filed a bug 398349.

Comment 14

[alexander :surkov (:asurkov)]

checked in, documentation is updated

Comment 15

[alexander :surkov (:asurkov)]

(In reply to comment #3)

> Can you fix the Mozilla testcase so it uses labelledby?
> http://www.mozilla.org/access/dhtml/tabpanel
> 

Do I need review before landing? I guess, no?

Comment 16

[Aaron Leventhal]

No, you don't need review before landing changes to the a11y testcases.