397004 - pageloader won't work with -tpchrome and self timing.

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[alice nodelman [:alice] [:anode]]

Attachment: removes bubbling onload handler from self timing tests

When working with self timing tests (those with '%' preceding the url in the manifest file) and the -tpchrome switch the pageloader fails with the message:

tp: Bubbling onload handler used with page that does its own timing?

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 281769 [details] [diff] [review]
removes bubbling onload handler from self timing tests

That would work, but I think you can just get rid of the addEventListener on line 153 -- that's where it's added in the first place.  That shouldn't be there, because it's automatically added and removed around each test; e.g. see the else clause of the place where you made the patch.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 281769 [details] [diff] [review]
removes bubbling onload handler from self timing tests

Oh, while you're there, can you fix the typo in "capturig"? :)

Comment 3

[alice nodelman [:alice] [:anode]]

Attachment: remove auto-add of bubbling onload handler

You are correct, removing it entirely fixes the problem.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 281839 [details] [diff] [review]
remove auto-add of bubbling onload handler

Great, thanks!

Comment 5

[alice nodelman [:alice] [:anode]]

Checking in pageloader.js;
/cvsroot/mozilla/layout/tools/pageloader/pageloader.js,v  <--  pageloader.js
new revision: 1.5; previous revision: 1.4
done