397225 - RSS feed preview page is broken

Status: VERIFIED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Build ID: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a9pre) Gecko/2007092204 Minefield/3.0a9pre

Summary: RSS feed subscription is broken.

Regression from bug 395496.

Steps to Reproduce:

1. Load http://jtbatson.blogspot.com/ (or any URL with an RSS feed)
2. Click on the RSS feed icon in the location bar
3. Choose "Subscribe to..." from the popup menu
 
Expected Results:

From there, I should be able to subscribe to the RSS feed

Actual Results:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIFeedWriter.init]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://browser/content/feeds/subscribe.js :: SH_init :: line 47"  data: no]

Error: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavHistoryService.removeObserver]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: file:///C:/Program%20Files/Minefield/components/FeedWriter.js :: FW_close :: line 792"  data: no]
Source File: file:///C:/Program%20Files/Minefield/components/FeedWriter.js
Line: 792

Comment 2

[pal-moz]

screen shot :
now, http://img507.imageshack.us/img507/1641/fv1bg0.jpg
before, http://img507.imageshack.us/img507/3516/fv2qs1.jpg

1) default readers (my yahoo,bloglines,google) are not displayed in drop down menu.
2) "always...." text is missing.
3) reader's favicon is missing. [additional]

Comment 3

[Daniel Brooks [:db48x]]

Subscribing to a feed works if you have Firefox set to skip the preview, so it's really only the preview page that's broken.

Comment 4

[Marcia Knous [:marcia]]

With a fresh profile using today's build I cannot add a feed at all from foxnews.com. When I check the checkbox then any subsequent visits to other pages allow me to add the feeds from those pages. So the initial feedback the user gets is that RSS may be broken.

(In reply to comment #3)
> Subscribing to a feed works if you have Firefox set to skip the preview, so
> it's really only the preview page that's broken.
> 

Comment 5

[Peter van der Woude [:Peter6]]

(In reply to comment #4)
> With a fresh profile using today's build I cannot add a feed at all from
> foxnews.com. When I check the checkbox then any subsequent visits to other
> pages allow me to add the feeds from those pages. So the initial feedback the
> user gets is that RSS may be broken.
> 
Confirmed, severity should really be Blocker for this one

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Setting as blocker since this is stopping us from testing.

Comment 7

[Hussam Al-Tayeb]

Not just Vista, it's broken on my Linux builds as well.

Comment 8

[u251854]

I can confirm.
Have a problem with this on Linux too.

Comment 9

[Asaf Romano (gone)]

Attachment: patch

Comment 10

[Asaf Romano (gone)]

Attachment: working...

Comment 11

[Asaf Romano (gone)]

mozilla/toolkit/content/widgets/menulist.xml 1.32

Comment 12

[pal-moz]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007092920 Minefield/3.0a9pre ID:2007092920

confirmed, fixed now.

BTW, no reader favicon on/in pull-down is intended or will be fixed ?

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #12)
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007092920
> Minefield/3.0a9pre ID:2007092920
> 
> confirmed, fixed now.
> 
> BTW, no reader favicon on/in pull-down is intended or will be fixed ?

I get reader favicons working on Mac, but in my XP SP2 VM, I don't see them until I mouse through the dropdown select list; it appears that it doesn't build them until selection, which is weird.

Pal, can you file a spin-off bug?

Comment 14

[pal-moz]

(In reply to comment #13)
> Pal, can you file a spin-off bug?
> 

filed, bug 398130

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007100505 Minefield/3.0a9pre and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a9pre) Gecko/2007100504 Minefield/3.0a9pre

Comment 16

[Neil Deakin]

Mano, why did you put the mutation listener back in to menulist here?

Comment 17

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #16)
> Mano, why did you put the mutation listener back in to menulist here?

Because addBroadcastListenerFor doesn't work in non-XUL documents (like the feed preview page).