Closed Bug 39726 Opened 24 years ago Closed 24 years ago

Type in editor/base/IMETextTxn.cpp?

Categories

(Core :: DOM: Editor, defect, P3)

x86
FreeBSD
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: Joerg.Brunsmann, Assigned: shanjian)

References

()

Details

Shouldn't 

if (otherTxn && NS_SUCCEEDED(NS_OK))

look like

if (otherTxn && NS_SUCCEEDED(result))

or

if (otherTxn)

??
assigning to ftang for confirmation on suggested change -- Frank, see line 167 
in the file
Assignee: beppe → ftang
Status: UNCONFIRMED → NEW
Ever confirmed: true
good catch ! shanjian, can you handl this ? 
Assignee: ftang → shanjian
Target Milestone: --- → M17
Status: NEW → ASSIGNED
I change the code and try it on my machine, it is correct.
I will checked it in when tree is open.
Index: IMETextTxn.cpp
===================================================================
RCS file: /cvsroot/mozilla/editor/base/IMETextTxn.cpp,v
retrieving revision 1.20
diff -r1.20 IMETextTxn.cpp
167c167
<   if (otherTxn && NS_SUCCEEDED(NS_OK))
---
>   if (otherTxn && NS_SUCCEEDED(result))
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
marking verified...code level fix.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.